-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Mbed docker image for CI #10645
Merged
andy31415
merged 2 commits into
project-chip:master
from
ARMmbed:fix-mbed-docker-image-for-ci
Oct 19, 2021
Merged
Fix Mbed docker image for CI #10645
andy31415
merged 2 commits into
project-chip:master
from
ARMmbed:fix-mbed-docker-image-for-ci
Oct 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple and
vivien-apple
October 19, 2021 08:03
pullapprove
bot
requested review from
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
October 19, 2021 08:03
saurabhst
approved these changes
Oct 19, 2021
PR #10645: Size comparison from 4c7f664 to ae33f7a 8 builds (for k32w, p6, qpg, telink)
14 builds (for efr32, linux, mbed)
2 builds (for esp32)
10 builds (for nrfconnect)
|
Damian-Nordic
approved these changes
Oct 19, 2021
andy31415
approved these changes
Oct 19, 2021
JasonLiuZhuoCheng
pushed a commit
to JasonLiuZhuoCheng/connectedhomeip
that referenced
this pull request
Oct 19, 2021
* Remove PW_ENVIRONMENT_ROOT env from mbed docker image * Bump docker image version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Mbed OS docker image included the PW_ENVIRONMENT_ROOT definition which causes that the default .environment directory is not created when we used the Mbed OS docker image directly. The CI workflow scripts refer to the .environment directory and that causes the fault.
PW_ENVIRONMENT_ROOT definition is redundant so we can remove it.
The issue is identified during #10619 and was caused by #9432 PR.
Change overview
Remove PW_ENVIRONMENT_ROOT env from Mbed docker image
Testing
Locally build and tested