Bump CI dockerfile version to 0.5.18 #10619

andy31415 · 2021-10-18T16:06:27Z

Problem

Docker image was updated, moving the CI builds (and vscode) to latest version, which will include new platforms (AmebaD in this case).

Change overview

Basically:

find .devcontainer .github -type f | xargs perl -p -i -e 's/0\.5\.15/0.5.18/'

(except I used the more comprehensive command to makse sure we do not have other paths somewhere else with this version)

rg '0\.5\.18' --hidden | cut -f1 -d: | uniq | grep -v \.git/ | xargs sd 0.5.15 0.5.18

Testing

CI will validate this.

bzbarsky-apple

This seems fine, but what is "rg" in the commit message? Is that "ripgrep"? And what is "sd"?

It might be better to use "git sed" for this sort of thing, at least in terms of things people can easily reproduce as needed....

github-actions · 2021-10-18T16:26:19Z

PR #10619: Size comparison from 5987dab to d1719d4

2 builds

platform	target	config	section	`5987dab`	`d1719d4`
p6	lock-app	default	.bss	68216	68216
			.data	2416	2416
			.heap	962712	962712
			.text	1126440	1126440
telink	lighting-app	tlsr9518adk80d	bss	71000	71000
			noinit	33216	33216
			text	458218	458218

30 builds

platform	target	config	section	`5987dab`	`d1719d4`
efr32	lighting-app	BRD4161A	.bss	118036	118036
			.data	1800	1800
			.text	782756	782756
	lock-app	BRD4161A	.bss	115892	115892
			.data	1760	1760
			.text	761900	761900
	window-app	BRD4161A	.bss	116212	116212
			.data	1764	1764
			.text	762824	762824
	lighting-app	BRD4161A+rpc	.bss	131364	131364
			.data	1852	1852
			.text	762500	762500
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296
			.dram0.data	16192	16192
			.flash.rodata	198784	198784
			.flash.text	870190	870190
			.iram0.text	57330	57330
		m5stack	.dram0.bss	62792	62792
			.dram0.data	32084	32084
			.flash.rodata	207216	207216
			.flash.text	900559	900559
			.iram0.text	125115	125115
k32w	lock-app	k32w061+debug	.bss	69052	69052
			.data	1864	1864
			.text	515336	515336
	shell	k32w061+debug	.bss	55080	55080
			.data	672	672
			.text	357332	357332
	lighting-app	k32w061+se05x+release	.bss	78576	78576
			.data	1900	1900
			.text	614120	614120
linux	all-clusters-app	debug	.bss	52176	52176
			.data	978	978
			.data.rel.ro	58688	58688
			.dynamic	592	592
			.got	4072	4072
			.init	27	27
			.init_array	512	512
			.rodata	135957	135957
			.text	`1327474`	`1327474`
	chip-tool	debug	.bss	17552	17552
			.data	1584	1584
			.data.rel.ro	84896	84896
			.dynamic	592	592
			.got	4336	4336
			.init	27	27
			.init_array	416	416
			.rodata	176928	176928
			.text	2458309	2458309
	ota-provider-app	debug	.bss	37472	37472
			.data	752	752
			.data.rel.ro	23176	23176
			.dynamic	592	592
			.got	4008	4008
			.init	27	27
			.init_array	440	440
			.rodata	109832	109832
			.text	1010322	1010322
	ota-requestor-app	debug	.bss	205728	205728
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4136	4136
			.init	27	27
			.init_array	512	512
			.rodata	128328	128328
			.text	1129634	1129634
	shell	debug	.bss	16072	16072
			.data	242	242
			.data.rel.ro	35120	35120
			.dynamic	592	592
			.got	3496	3496
			.init	27	27
			.init_array	336	336
			.rodata	71855	71855
			.text	569858	569858
	tv-app	debug	.bss	216400	216400
			.data	2032	2032
			.data.rel.ro	55872	55872
			.dynamic	592	592
			.got	4400	4400
			.init	27	27
			.init_array	608	608
			.rodata	151848	151848
			.text	1464210	1464210
	bridge-app	debug+rpc	.bss	52912	52912
			.data	976	976
			.data.rel.ro	25784	25784
			.dynamic	592	592
			.got	3944	3944
			.init	27	27
			.init_array	400	400
			.rodata	110452	110452
			.text	1052229	1052229
	lighting-app	debug+rpc	.bss	42232	42232
			.data	1106	1106
			.data.rel.ro	52496	52496
			.dynamic	608	608
			.got	4104	4104
			.init	27	27
			.init_array	528	528
			.rodata	127665	127665
			.text	`1253634`	`1253634`
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332
			rodata	97688	97688
			text	577560	577560
	lock-app	nrf52840dk_nrf52840	bss	111348	111348
			rodata	94028	94028
			text	559060	559060
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772
			rodata	45772	45772
			text	339392	339392
	pump-app	nrf52840dk_nrf52840	bss	111416	111416
			rodata	95008	95008
			text	562216	562216
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356
			rodata	94088	94088
			text	558852	558852
	shell	nrf52840dk_nrf52840	bss	107316	107316
			rodata	71640	71640
			text	519032	519032
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572
			rodata	88480	88480
			text	550764	550764
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704
			rodata	92932	92932
			text	507020	507020
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720
			rodata	89284	89284
			text	488516	488516
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300
			rodata	66284	66284
			text	439632	439632
qpg	lighting-app	qpg6100+debug	.bss	53552	53552
			.data	996	996
			.text	486432	486432
	lock-app	qpg6100+debug	.bss	52488	52488
			.data	952	952
			.text	462520	462520
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704

andy31415 · 2021-10-18T16:28:27Z

This seems fine, but what is "rg" in the commit message? Is that "ripgrep"? And what is "sd"?

It might be better to use "git sed" for this sort of thing, at least in terms of things people can easily reproduce as needed....

Thought it would be somewhat obvious what it does even if commands are not as common. I am using some rust binutils:

https://github.com/behnam/rust-ripgrep
https://github.com/chmln/sd

would it be sufficient to say 'replaced 0.5.15 with 0.5.17 using CLI script' without saying what commands I actually used?

andy31415 · 2021-10-18T16:30:30Z

It looks like the MBedOS changes do not let things compile anymore.

@ATmobica for #9432 ?

bzbarsky-apple · 2021-10-18T16:41:53Z

I think saying the actual commands is better; just if they're not commands that are normally present on a typical unixy system (including "git sed", which comes from the git-extras package) it's worth pointing to where the commands come from.

andy31415 · 2021-10-18T16:55:58Z

I think saying the actual commands is better; just if they're not commands that are normally present on a typical unixy system (including "git sed", which comes from the git-extras package) it's worth pointing to where the commands come from.

Replacing it with:

find .devcontainer .github -type f | xargs perl -p -i -e 's/0\.5\.15/0.5.17/'

andy31415 · 2021-10-18T18:18:10Z

It looks like the MBedOS changes do not let things compile anymore.

@ATmobica for #9432 ?

Saw that PR seems to include a line of ENV PW_ENVIRONMENT_ROOT=/home/vscode/pigweed/env which I missed during the review: that line seems wrong as vscode should not be a user in a general build. There should be no reason to change/hardcode the PW_ENVIRONMENT_ROOT, especially to a non-existent user home.

todo · 2021-10-18T19:28:13Z

find out why 0.5.16 image update fails to build mbedos binaries

connectedhomeip/.github/workflows/examples-mbed.yaml

Lines 43 to 46 in 4b90e10

    
           # TODO: find out why 0.5.16 image update fails to build mbedos binaries 
        
           image: connectedhomeip/chip-build-mbed-os:0.5.15 
        
           volumes: 
        
               - "/tmp/bloat_reports:/tmp/bloat_reports"

This comment was generated by todo based on a `TODO` comment in `4b90e10` in #10619. cc @andy31415.

andy31415 · 2021-10-18T19:29:03Z

I rolled back the mbedos moving to the latest docker image. I kept that one pinned to 0.5.15 for now.

github-actions · 2021-10-18T20:06:33Z

PR #10619: Size comparison from 4f389d5 to 299fd75

16 builds

platform	target	config	section	`4f389d5`	`299fd75`
k32w	lock-app	k32w061+debug	.bss	69052	69052
			.data	1864	1864
			.text	515352	515352
	shell	k32w061+debug	.bss	55080	55080
			.data	672	672
			.text	357332	357332
	lighting-app	k32w061+se05x+release	.bss	78576	78576
			.data	1900	1900
			.text	614136	614136
linux	all-clusters-app	debug	.bss	52176	52176
			.data	978	978
			.data.rel.ro	58688	58688
			.dynamic	592	592
			.got	4072	4072
			.init	27	27
			.init_array	512	512
			.rodata	136149	136149
			.text	1344930	1344930
	chip-tool	debug	.bss	17552	17552
			.data	1584	1584
			.data.rel.ro	86192	86192
			.dynamic	592	592
			.got	4344	4344
			.init	27	27
			.init_array	416	416
			.rodata	178476	178476
			.text	`2859461`	`2859461`
	ota-provider-app	debug	.bss	37472	37472
			.data	752	752
			.data.rel.ro	23176	23176
			.dynamic	592	592
			.got	4008	4008
			.init	27	27
			.init_array	440	440
			.rodata	109832	109832
			.text	1010354	1010354
	ota-requestor-app	debug	.bss	205728	205728
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4136	4136
			.init	27	27
			.init_array	512	512
			.rodata	128328	128328
			.text	1129666	1129666
	shell	debug	.bss	16072	16072
			.data	242	242
			.data.rel.ro	35120	35120
			.dynamic	592	592
			.got	3496	3496
			.init	27	27
			.init_array	336	336
			.rodata	71855	71855
			.text	569858	569858
	tv-app	debug	.bss	216400	216400
			.data	2032	2032
			.data.rel.ro	55872	55872
			.dynamic	592	592
			.got	4400	4400
			.init	27	27
			.init_array	608	608
			.rodata	151848	151848
			.text	1464242	1464242
	bridge-app	debug+rpc	.bss	52912	52912
			.data	976	976
			.data.rel.ro	25784	25784
			.dynamic	592	592
			.got	3944	3944
			.init	27	27
			.init_array	400	400
			.rodata	110452	110452
			.text	1052389	1052389
	lighting-app	debug+rpc	.bss	42232	42232
			.data	1106	1106
			.data.rel.ro	52496	52496
			.dynamic	608	608
			.got	4104	4104
			.init	27	27
			.init_array	528	528
			.rodata	127665	127665
			.text	`1253666`	`1253666`
p6	lock-app	default	.bss	68216	68216
			.data	2416	2416
			.heap	962712	962712
			.text	1126472	1126472
qpg	lighting-app	qpg6100+debug	.bss	53552	53552
			.data	996	996
			.text	486448	486448
	lock-app	qpg6100+debug	.bss	52488	52488
			.data	952	952
			.text	462520	462520
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704
telink	lighting-app	tlsr9518adk80d	bss	71000	71000
			noinit	33216	33216
			text	458220	458220

6 builds

platform	target	config	section	`4f389d5`	`299fd75`
efr32	lighting-app	BRD4161A	.bss	118036	118036
			.data	1800	1800
			.text	782788	782788
	lock-app	BRD4161A	.bss	115892	115892
			.data	1760	1760
			.text	761932	761932
	window-app	BRD4161A	.bss	116212	116212
			.data	1764	1764
			.text	762840	762840
	lighting-app	BRD4161A+rpc	.bss	131364	131364
			.data	1852	1852
			.text	762532	762532
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164
			.data	5464	5464
			.heap	858816	858816
			.text	1219800	1219800
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197632	1197632

12 builds

platform	target	config	section	`4f389d5`	`299fd75`	change	% change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0	0.0
			.dram0.data	16192	16192	0	0.0
			.flash.rodata	198896	198896	0	0.0
			.flash.text	872534	872534	0	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62792	62792	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207320	207320	0	0.0
			.flash.text	902815	902723	-92	-0.0
			.iram0.text	125115	125115	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332	0	0.0
			rodata	97688	97688	0	0.0
			text	577568	577568	0	0.0
	lock-app	nrf52840dk_nrf52840	bss	111348	111348	0	0.0
			rodata	94028	94028	0	0.0
			text	559068	559068	0	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772	0	0.0
			rodata	45772	45772	0	0.0
			text	339392	339392	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	111416	111416	0	0.0
			rodata	95008	95008	0	0.0
			text	562224	562224	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356	0	0.0
			rodata	94088	94088	0	0.0
			text	558860	558860	0	0.0
	shell	nrf52840dk_nrf52840	bss	107316	107316	0	0.0
			rodata	71640	71640	0	0.0
			text	519032	519032	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572	0	0.0
			rodata	88480	88480	0	0.0
			text	550772	550772	0	0.0
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704	0	0.0
			rodata	92932	92932	0	0.0
			text	507032	507032	0	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720	0	0.0
			rodata	89284	89284	0	0.0
			text	488528	488528	0	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300	0	0.0
			rodata	66284	66284	0	0.0
			text	439632	439632	0	0.0

andy31415 · 2021-10-19T13:31:22Z

Updated to 0.5.18 since that fixes mbedOS as well.

github-actions · 2021-10-19T13:54:36Z

PR #10619: Size comparison from 83dfc06 to 918c66f

8 builds (for k32w, p6, qpg, telink)

platform	target	config	section	`83dfc06`	`918c66f`
k32w	lock-app	k32w061+debug	.bss	69052	69052
			.data	1864	1864
			.text	515520	515520
	shell	k32w061+debug	.bss	55080	55080
			.data	672	672
			.text	357332	357332
	lighting-app	k32w061+se05x+release	.bss	78576	78576
			.data	1900	1900
			.text	614304	614304
p6	lock-app	default	.bss	68216	68216
			.data	2416	2416
			.heap	962712	962712
			.text	1126624	1126624
qpg	lighting-app	qpg6100+debug	.bss	53552	53552
			.data	996	996
			.text	486616	486616
	lock-app	qpg6100+debug	.bss	52488	52488
			.data	952	952
			.text	462684	462684
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704
telink	lighting-app	tlsr9518adk80d	bss	71000	71000
			noinit	33216	33216
			text	458304	458304

14 builds (for efr32, linux, mbed)

platform	target	config	section	`83dfc06`	`918c66f`
efr32	lighting-app	BRD4161A	.bss	118036	118036
			.data	1800	1800
			.text	782944	782944
	lock-app	BRD4161A	.bss	115892	115892
			.data	1760	1760
			.text	762088	762088
	window-app	BRD4161A	.bss	116212	116212
			.data	1764	1764
			.text	763012	763012
	lighting-app	BRD4161A+rpc	.bss	131364	131364
			.data	1852	1852
			.text	762700	762700
linux	all-clusters-app	debug	.bss	52176	52176
			.data	978	978
			.data.rel.ro	58688	58688
			.dynamic	592	592
			.got	4072	4072
			.init	27	27
			.init_array	512	512
			.rodata	136373	136373
			.text	1345186	1345186
	chip-tool	debug	.bss	17552	17552
			.data	1584	1584
			.data.rel.ro	86192	86192
			.dynamic	592	592
			.got	4344	4344
			.init	27	27
			.init_array	416	416
			.rodata	178892	178892
			.text	`2859941`	`2859941`
	ota-provider-app	debug	.bss	37472	37472
			.data	752	752
			.data.rel.ro	23176	23176
			.dynamic	592	592
			.got	4008	4008
			.init	27	27
			.init_array	440	440
			.rodata	110056	110056
			.text	1010594	1010594
	ota-requestor-app	debug	.bss	205728	205728
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4136	4136
			.init	27	27
			.init_array	512	512
			.rodata	128744	128744
			.text	1130130	1130130
	shell	debug	.bss	16072	16072
			.data	242	242
			.data.rel.ro	35120	35120
			.dynamic	592	592
			.got	3496	3496
			.init	27	27
			.init_array	336	336
			.rodata	71855	71855
			.text	569858	569858
	tv-app	debug	.bss	216400	216400
			.data	2032	2032
			.data.rel.ro	55872	55872
			.dynamic	592	592
			.got	4400	4400
			.init	27	27
			.init_array	608	608
			.rodata	152264	152264
			.text	1464706	1464706
	bridge-app	debug+rpc	.bss	52912	52912
			.data	976	976
			.data.rel.ro	25784	25784
			.dynamic	592	592
			.got	3944	3944
			.init	27	27
			.init_array	400	400
			.rodata	110644	110644
			.text	1052629	1052629
	lighting-app	debug+rpc	.bss	42232	42232
			.data	1106	1106
			.data.rel.ro	52496	52496
			.dynamic	608	608
			.got	4104	4104
			.init	27	27
			.init_array	528	528
			.rodata	127857	127857
			.text	1253906	1253906
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172164	172164
			.data	5464	5464
			.heap	858816	858816
			.text	1219944	1219944
	lock-app	CY8CPROTO_062_4343W+release	.bss	171084	171084
			.data	5432	5432
			.heap	859928	859928
			.text	1197840	1197840

2 builds (for esp32)

platform	target	config	section	`83dfc06`	`918c66f`	change
esp32	all-clusters-app	c3devkit	.dram0.bss	60296	60296	0
			.dram0.data	16192	16192	0
			.flash.rodata	199008	199008	0
			.flash.text	872638	872638	0
			.iram0.text	57330	57330	0
		m5stack	.dram0.bss	62792	62792	0
			.dram0.data	32084	32084	0
			.flash.rodata	207432	207432	0
			.flash.text	902739	902831	92
			.iram0.text	125115	125115	0

10 builds (for nrfconnect)

platform	target	config	section	`83dfc06`	`918c66f`
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112332	112332
			rodata	97776	97776
			text	577652	577652
	lock-app	nrf52840dk_nrf52840	bss	111348	111348
			rodata	94112	94112
			text	559152	559152
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772
			rodata	45772	45772
			text	339392	339392
	pump-app	nrf52840dk_nrf52840	bss	111416	111416
			rodata	95092	95092
			text	562308	562308
	pump-controller-app	nrf52840dk_nrf52840	bss	111356	111356
			rodata	94172	94172
			text	558944	558944
	shell	nrf52840dk_nrf52840	bss	107316	107316
			rodata	71640	71640
			text	519032	519032
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108572	108572
			rodata	88560	88560
			text	550856	550856
		nrf5340dk_nrf5340_cpuapp	bss	113704	113704
			rodata	93016	93016
			text	507116	507116
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112720	112720
			rodata	89372	89372
			text	488612	488612
	shell	nrf5340dk_nrf5340_cpuapp	bss	108300	108300
			rodata	66284	66284
			text	439632	439632

* Update used docker version to latest * Roll back mbedos docker image usage * Update to 0.5.18 since that fixes mbedOS

Update used docker version to latest

d1719d4

boring-cyborg bot added github integrations vscode workflows labels Oct 18, 2021

pullapprove bot requested review from wbschiller and woody-apple October 18, 2021 16:11

pullapprove bot added the review - pending label Oct 18, 2021

bzbarsky-apple approved these changes Oct 18, 2021

View reviewed changes

andy31415 mentioned this pull request Oct 18, 2021

Mbed OS docker image cleanup #9432

Merged

Roll back mbedos docker image usage

4b90e10

Merge branch 'master' into update_dockerfile_version

299fd75

andy31415 mentioned this pull request Oct 18, 2021

Fix cloudbuild: building "all" now includes AmebaD which requires newer Docker image #10626

Merged

LuDuda approved these changes Oct 18, 2021

View reviewed changes

ATmobica mentioned this pull request Oct 19, 2021

Fix Mbed docker image for CI #10645

Merged

andy31415 added 2 commits October 19, 2021 09:29

Merge branch 'master' into update_dockerfile_version

611ae77

Update to 0.5.18 since that fixes mbedOS

918c66f

andy31415 changed the title ~~Bump CI dockerfile version to 0.5.17~~ Bump CI dockerfile version to 0.5.18 Oct 19, 2021

kghost approved these changes Oct 19, 2021

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Oct 19, 2021

andy31415 merged commit 09519d8 into project-chip:master Oct 19, 2021

andy31415 deleted the update_dockerfile_version branch October 28, 2021 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump CI dockerfile version to 0.5.18 #10619

Bump CI dockerfile version to 0.5.18 #10619

andy31415 commented Oct 18, 2021 •

edited

Loading

bzbarsky-apple left a comment

github-actions bot commented Oct 18, 2021 •

edited

Loading

andy31415 commented Oct 18, 2021

andy31415 commented Oct 18, 2021

bzbarsky-apple commented Oct 18, 2021

andy31415 commented Oct 18, 2021

andy31415 commented Oct 18, 2021

todo bot commented Oct 18, 2021

andy31415 commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 •

edited

Loading

andy31415 commented Oct 19, 2021

github-actions bot commented Oct 19, 2021 •

edited

Loading

Bump CI dockerfile version to 0.5.18 #10619

Bump CI dockerfile version to 0.5.18 #10619

Conversation

andy31415 commented Oct 18, 2021 • edited Loading

Problem

Change overview

Testing

bzbarsky-apple left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 18, 2021 • edited Loading

andy31415 commented Oct 18, 2021

andy31415 commented Oct 18, 2021

bzbarsky-apple commented Oct 18, 2021

andy31415 commented Oct 18, 2021

andy31415 commented Oct 18, 2021

todo bot commented Oct 18, 2021

find out why 0.5.16 image update fails to build mbedos binaries

This comment was generated by todo based on a TODO comment in 4b90e10 in #10619. cc @andy31415.

andy31415 commented Oct 18, 2021

github-actions bot commented Oct 18, 2021 • edited Loading

andy31415 commented Oct 19, 2021

github-actions bot commented Oct 19, 2021 • edited Loading

andy31415 commented Oct 18, 2021 •

edited

Loading

github-actions bot commented Oct 18, 2021 •

edited

Loading

This comment was generated by todo based on a `TODO` comment in `4b90e10` in #10619. cc @andy31415.

github-actions bot commented Oct 18, 2021 •

edited

Loading

github-actions bot commented Oct 19, 2021 •

edited

Loading