Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable LGTM #37

Closed
woody-apple opened this issue Mar 11, 2020 · 3 comments
Closed

Enable LGTM #37

woody-apple opened this issue Mar 11, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone
V1.0

Comments

@woody-apple
Copy link
Contributor

We should enable LGTM as soon as possible for all PRs:
https://github.com/marketplace/lgtm
@woody-apple woody-apple added the enhancement New feature or request label Mar 11, 2020
@woody-apple woody-apple self-assigned this Mar 11, 2020
@gerickson
Copy link
Contributor

We also use Coverity, which supports public, open source projects free of charge. Between LGTM, clang static analysis, and Coverity, there is a non-overlapping Venn diagram of issues caught.

@woody-apple woody-apple mentioned this issue Mar 11, 2020
Closed
@woody-apple
Copy link
Contributor Author

I'm 100% on adding Coverity. The LGTM came from an internal recommendation, but let's add more. 👍 No complaints here

@rwalker-apple rwalker-apple added this to the Needs Milestone milestone Mar 20, 2020
@woody-apple woody-apple modified the milestones: Not sure when, V1.0 May 19, 2020
@woody-apple
Copy link
Contributor Author

Done

restyled-io bot pushed a commit that referenced this issue Sep 3, 2021
@hnnajh
Merge pull request #37 from project-chip/master
0cba65f 
Update master
@yunhanw-google yunhanw-google mentioned this issue Dec 8, 2021
Closed
@ghost ghost mentioned this issue Dec 9, 2021
Closed
@yunhanw-google yunhanw-google mentioned this issue Apr 28, 2022
Closed
@wilbur-se wilbur-se mentioned this issue May 10, 2022
Closed
jmartinez-silabs referenced this issue in SiliconLabs/matter Aug 18, 2022
@jmartinez-silabs
Pull request #37: ✏️ Corrections to Color Light app's README.md
4abb73c 
Merge in WMN_TOOLS/matter from example_newLight to silabs

Squashed commit of the following:

commit bd7741e6bddc73d701988f956488d5c95a757773
Author: Elfelsoufi-SiLabs <[email protected]>
Date:   Thu Aug 4 20:01:00 2022 -0400

    ✏️  Corrections to Color Light app's README.md
jmartinez-silabs referenced this issue in SiliconLabs/matter Sep 8, 2022
@jmartinez-silabs
Pull request #37: ✏️ Corrections to Color Light app's README.md
2c35462 
Merge in WMN_TOOLS/matter from example_newLight to silabs

Squashed commit of the following:

commit bd7741e6bddc73d701988f956488d5c95a757773
Author: Elfelsoufi-SiLabs <[email protected]>
Date:   Thu Aug 4 20:01:00 2022 -0400

    ✏️  Corrections to Color Light app's README.md
lpbeliveau-silabs pushed a commit to lpbeliveau-silabs/connectedhomeip that referenced this issue Sep 12, 2022
@jmartinez-silabs
Pull request project-chip#37: ✏️ Corrections to Color Light app's REA…
7ec8aaf 
…DME.md

Merge in WMN_TOOLS/matter from example_newLight to silabs

Squashed commit of the following:

commit bd7741e6bddc73d701988f956488d5c95a757773
Author: Elfelsoufi-SiLabs <[email protected]>
Date:   Thu Aug 4 20:01:00 2022 -0400

    ✏️  Corrections to Color Light app's README.md
nipatel-silabs pushed a commit to nipatel-silabs/connectedhomeip that referenced this issue Oct 19, 2022
@jmartinez-silabs
Pull request project-chip#37: ✏️ Corrections to Color Light app's REA…
d0ce809 
…DME.md

Merge in WMN_TOOLS/matter from example_newLight to silabs

Squashed commit of the following:

commit bd7741e6bddc73d701988f956488d5c95a757773
Author: Elfelsoufi-SiLabs <[email protected]>
Date:   Thu Aug 4 20:01:00 2022 -0400

    ✏️  Corrections to Color Light app's README.md
jculbert pushed a commit to jculbert/connectedhomeip that referenced this issue Jan 10, 2023
@jmartinez-silabs
Pull request project-chip#37: ✏️ Corrections to Color Light app's REA…
50d67bd 
…DME.md

Merge in WMN_TOOLS/matter from example_newLight to silabs

Squashed commit of the following:

commit bd7741e6bddc73d701988f956488d5c95a757773
Author: Elfelsoufi-SiLabs <[email protected]>
Date:   Thu Aug 4 20:01:00 2022 -0400

    ✏️  Corrections to Color Light app's README.md
Thirsrin pushed a commit to Thirsrin/connectedhomeip that referenced this issue Jul 12, 2023
@jmartinez-silabs
Pull request project-chip#37: ✏️ Corrections to Color Light app's REA…
3762049 
…DME.md

Merge in WMN_TOOLS/matter from example_newLight to silabs

Squashed commit of the following:

commit bd7741e6bddc73d701988f956488d5c95a757773
Author: Elfelsoufi-SiLabs <[email protected]>
Date:   Thu Aug 4 20:01:00 2022 -0400

    ✏️  Corrections to Color Light app's README.md
shgutte pushed a commit to shgutte/connectedhomeip that referenced this issue Oct 5, 2023
@jmartinez-silabs
Pull request project-chip#37: ✏️ Corrections to Color Light app's REA…
1a1d386 
…DME.md

Merge in WMN_TOOLS/matter from example_newLight to silabs

Squashed commit of the following:

commit bd7741e6bddc73d701988f956488d5c95a757773
Author: Elfelsoufi-SiLabs <[email protected]>
Date:   Thu Aug 4 20:01:00 2022 -0400

    ✏️  Corrections to Color Light app's README.md
@M201370367 M201370367 mentioned this issue Oct 25, 2023
Open
@joonhaengHeo joonhaengHeo mentioned this issue Dec 20, 2023
Closed
@pgatti86 pgatti86 mentioned this issue Dec 22, 2023
Closed
shgutte pushed a commit to shgutte/connectedhomeip that referenced this issue Jan 11, 2024
@jmartinez-silabs
Pull request project-chip#37: ✏️ Corrections to Color Light app's REA…
4f2a741 
…DME.md

Merge in WMN_TOOLS/matter from example_newLight to silabs

Squashed commit of the following:

commit bd7741e6bddc73d701988f956488d5c95a757773
Author: Elfelsoufi-SiLabs <[email protected]>
Date:   Thu Aug 4 20:01:00 2022 -0400

    ✏️  Corrections to Color Light app's README.md
@JasonClark2 JasonClark2 mentioned this issue Apr 3, 2024
Open
suveshpratapa pushed a commit to suveshpratapa/connectedhomeip that referenced this issue May 22, 2024
@jmartinez-silabs
Pull request project-chip#37: ✏️ Corrections to Color Light app's REA…
51b14ec 
…DME.md

Merge in WMN_TOOLS/matter from example_newLight to silabs

Squashed commit of the following:

commit bd7741e6bddc73d701988f956488d5c95a757773
Author: Elfelsoufi-SiLabs <[email protected]>
Date:   Thu Aug 4 20:01:00 2022 -0400

    ✏️  Corrections to Color Light app's README.md
mykrupp pushed a commit to mykrupp/connectedhomeip that referenced this issue Jul 18, 2024
@jmartinez-silabs
Pull request project-chip#37: ✏️ Corrections to Color Light app's REA…
10c7072 
…DME.md

Merge in WMN_TOOLS/matter from example_newLight to silabs

Squashed commit of the following:

commit bd7741e6bddc73d701988f956488d5c95a757773
Author: Elfelsoufi-SiLabs <[email protected]>
Date:   Thu Aug 4 20:01:00 2022 -0400

    ✏️  Corrections to Color Light app's README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
V1.0
Development

No branches or pull requests
4 participants
@gerickson @kidip @woody-apple @rwalker-apple