Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XML] Update OnOff Cluster XML to match updated spec #27092

Closed
ReneJosefsen opened this issue Jun 6, 2023 · 1 comment · Fixed by #29404
Closed

[XML] Update OnOff Cluster XML to match updated spec #27092

ReneJosefsen opened this issue Jun 6, 2023 · 1 comment · Fixed by #29404
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)
Milestone
1.3 Feature Complete

Comments

@ReneJosefsen
Copy link
Contributor

ReneJosefsen commented Jun 6, 2023 •
edited
Loading

The data types names has been updated in OnOff Cluster and must be updated in the XML as well.

Added:

  • OnOffControlBitmap
  • EffectIdentifierEnum
  • DelayedAllOffEffectVariantEnum
  • DyingLightEffectVariantEnum

Changed feature names:

  • Level Control for Lighting -> Lighting
  • Dead Front Behaviour -> DeadFrontBehaviour

Adjusted value names in DelayedAllOffEffectVariantEnum and DyingLightEffectVariantEnum:

  • FadeToOffIn_0p8Seconds -> DelayedOffFastFade
  • 50PercentDimDownIn_0p8SecondsThenFadeToOffIn_12Seconds -> DelayedOffSlowFade
  • 20PercentDimUpIn_0p5SecondsThenFadeToOffIn_1Second -> DyingLightFadeOff

Spec PR: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6511 (already merged)
@bzbarsky-apple bzbarsky-apple added the Spec XML align SDK XML does not match the spec (including naming, etc) label Jun 6, 2023
@bzbarsky-apple
Copy link
Contributor

I am not sure whether it's worth working on this until whatever changes are needed for https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/6336 happen too.... Right now the XML in the SDK cannot in fact be aligned with the spec.

@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 13, 2023
Closed
@woody-apple woody-apple added this to the 1.3 milestone Aug 31, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 22, 2023
@bzbarsky-apple
Align On/Off cluster XML with the spec.
598492e 
Updates to the changes from
CHIP-Specifications/connectedhomeip-spec#6511 and fixes
some other bugs (e.g. incorrect "DeadFrontBehavior" feature name).

Fixes project-chip#27092
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 22, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 22, 2023
@bzbarsky-apple
Align On/Off cluster XML with the spec.
6f80989 
Updates to the changes from
CHIP-Specifications/connectedhomeip-spec#6511 and fixes
some other bugs (e.g. incorrect "DeadFrontBehavior" feature name).

Fixes project-chip#27092
@mergify mergify bot closed this as completed in #29404 Sep 22, 2023
mergify bot pushed a commit that referenced this issue Sep 22, 2023
@bzbarsky-apple
Align On/Off cluster XML with the spec. (#29404)
6fe4b11 
* Align On/Off cluster XML with the spec.

Updates to the changes from
CHIP-Specifications/connectedhomeip-spec#6511 and fixes
some other bugs (e.g. incorrect "DeadFrontBehavior" feature name).

Fixes #27092

* Auto-update .zap files.

* Regenerate generated code.
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Align On/Off cluster XML with the spec. (project-chip#29404)
e952827 
* Align On/Off cluster XML with the spec.

Updates to the changes from
CHIP-Specifications/connectedhomeip-spec#6511 and fixes
some other bugs (e.g. incorrect "DeadFrontBehavior" feature name).

Fixes project-chip#27092

* Auto-update .zap files.

* Regenerate generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)
Projects
[1.3] SDK Feature Complete
Archived in project
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
1.3 Feature Complete
Development

Successfully merging a pull request may close this issue.

Align On/Off cluster XML with the spec. bzbarsky-apple/connectedhomeip
3 participants
@woody-apple @bzbarsky-apple @ReneJosefsen