-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align On/Off cluster XML with the spec. #29404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #29404: Size comparison from 05bcbec to 86e6522 Increases (10 builds for bl702, bl702l, cc32xx, psoc6)
Decreases (6 builds for cc32xx, efr32, linux, psoc6, qpg)
Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Updates to the changes from CHIP-Specifications/connectedhomeip-spec#6511 and fixes some other bugs (e.g. incorrect "DeadFrontBehavior" feature name). Fixes project-chip#27092
bzbarsky-apple
force-pushed
the
align-on-off-xml
branch
from
September 22, 2023 04:54
86e6522
to
bf2045b
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
September 22, 2023 04:55
pullapprove
bot
requested review from
mkardous-silabs,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 22, 2023 04:55
PR #29404: Size comparison from 05bcbec to bf2045b Increases (10 builds for bl702, bl702l, cc32xx, psoc6)
Decreases (9 builds for bl702, cc32xx, efr32, linux, psoc6, qpg)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 22, 2023
saurabhst
approved these changes
Sep 22, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Align On/Off cluster XML with the spec. Updates to the changes from CHIP-Specifications/connectedhomeip-spec#6511 and fixes some other bugs (e.g. incorrect "DeadFrontBehavior" feature name). Fixes project-chip#27092 * Auto-update .zap files. * Regenerate generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the changes from
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6511 and fixes
some other bugs (e.g. incorrect "DeadFrontBehavior" feature name).
REVIEW NOTE: Only the first commit of the three is manually written (and even that involved a lot of
git sed
). The other two are auto-generated.