Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectPool leaks in InteractionModelEngine #12504

Closed
kpschoedel opened this issue Dec 2, 2021 · 0 comments · Fixed by #12702
Closed

ObjectPool leaks in InteractionModelEngine #12504

kpschoedel opened this issue Dec 2, 2021 · 0 comments · Fixed by #12702
Assignees
@kpschoedel
Labels
leak Memory leak bug

Comments

@kpschoedel
Copy link
Contributor

Problem

InteractionModelEngine::mTimedHandlers had live objects on destruction, in a TestTimedHandler unit test.

(Replacing issue #11880 Possible use of destroyed pool objects with specific issues for the few remaining instances.)

Proposed Solution

Someone with domain knowledge should decide where/whether remaining pool objects should be released (e.g. calling ReleaseAll() in the enclosing class's destructor), or whether some other action should be taken (e.g. extending the lifetime of the enclosing class instances).
@kpschoedel kpschoedel mentioned this issue Dec 2, 2021
Merged
@kpschoedel kpschoedel added the leak Memory leak bug label Dec 7, 2021
@kpschoedel kpschoedel self-assigned this Dec 7, 2021
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Dec 7, 2021
@kpschoedel
Fix ObjectPool leaks in InteractionModelEngine
aa3d709 
#### Problem

Fixes project-chip#12504 ObjectPool leaks in InteractionModelEngine

#### Change overview

Call `ReleaseAll()` in `InteractionModelEngine::Shutdown()`;
since the comments there indicate that was the intent.

#### Testing

CI; no changes to external functionality.
@kpschoedel kpschoedel mentioned this issue Dec 7, 2021
Merged
andy31415 pushed a commit that referenced this issue Dec 8, 2021
@kpschoedel
Fix ObjectPool leaks in InteractionModelEngine (#12702)
0aedea7 
#### Problem

Fixes #12504 ObjectPool leaks in InteractionModelEngine

#### Change overview

Call `ReleaseAll()` in `InteractionModelEngine::Shutdown()`;
since the comments there indicate that was the intent.

#### Testing

CI; no changes to external functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpschoedel kpschoedel

Labels
leak Memory leak bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ObjectPool leaks in InteractionModelEngine kpschoedel/connectedhomeip
1 participant
@kpschoedel