Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit AccessControl system and add more tests #10253

Open
mlepage-google opened this issue Oct 5, 2021 · 2 comments
Open

Audit AccessControl system and add more tests #10253

mlepage-google opened this issue Oct 5, 2021 · 2 comments
Assignees
@mlepage-google
Labels
acl Access Control feature stale Stale issue or PR testing v1.1

Comments

@mlepage-google
Copy link
Contributor

mlepage-google commented Oct 5, 2021 •
edited
Loading

  • once everything is in place (plumbing from messaging layer, plumbing through IM, AccessControlProvider, etc.)
  • this task is to audit everything to ensure it's all functioning, robust, and performant
  • add more tests for the cluster and its functions (e.g. in YAML)
@mlepage-google mlepage-google added the acl Access Control feature label Oct 5, 2021
@mlepage-google mlepage-google changed the title Audit AccessControl system Audit AccessControl system and add more tests Jan 11, 2022
@mlepage-google mlepage-google mentioned this issue Jan 11, 2022
Merged
@mlepage-google mlepage-google self-assigned this Jan 31, 2022
This was referenced Jan 31, 2022
Merged
Merged
Closed
@woody-apple woody-apple added testing and removed cert labels Feb 8, 2022
mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Feb 15, 2022
@mlepage-google
Add simple YAML test for access control cluster
cd249cc 
This is a very simple test for now.
I will come back and add lots more.

Towards issue project-chip#10253
@mlepage-google mlepage-google mentioned this issue Feb 15, 2022
Merged
woody-apple pushed a commit to mlepage-google/connectedhomeip that referenced this issue Feb 17, 2022
@mlepage-google @andy31415
Add simple YAML test for access control cluster
b639ba3 
This is a very simple test for now.
I will come back and add lots more.

Towards issue project-chip#10253
mlepage-google added a commit that referenced this issue Feb 18, 2022
@mlepage-google
Add simple YAML test for access control cluster (#15210)
2353c7d 
Simple tests for now, more will be added later.

Towards issue #10253
mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue Feb 25, 2022
@mlepage-google
Add more YAML tests for Access Control Cluster
1522d0d 
- Test some invalid entries
- Test some too many entries

Part of project-chip#10253
@erjiaqing erjiaqing mentioned this issue Mar 2, 2022
Merged
mlepage-google added a commit that referenced this issue Mar 2, 2022
@mlepage-google @yunhanw-google
Add more YAML tests for Access Control Cluster (#15589)
c2a5710 
* Add more YAML tests for Access Control Cluster

- Test some invalid entries
- Test some too many entries

Part of #10253

* Fix issue 13075

--When mQueueLength >= mQueueSize happens in CHIPCircularTLVBuffer::GetNewBuffer, if mProcessEvictedElement is set with AlwaysFail, EvictHead would fail when logging Event. We should let EvictHead and Init succeed, then later EnsureSpaceInCircularBuffer
would help get enough space for new event in LogEventPrivate.

add event overflow testing

Co-authored-by: Yunhan Wang <[email protected]>
@stale
Copy link

stale bot commented Dec 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

1 similar comment
@stale
Copy link

stale bot commented Jun 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlepage-google mlepage-google

Labels
acl Access Control feature stale Stale issue or PR testing v1.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andy31415 @woody-apple @mlepage-google