Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ReadSingleClusterData and WriteSingleClusterData #13486

Closed
erjiaqing opened this issue Jan 12, 2022 · 2 comments
Closed

Refactor ReadSingleClusterData and WriteSingleClusterData #13486

erjiaqing opened this issue Jan 12, 2022 · 2 comments
Labels
stale Stale issue or PR V1.X

Comments

@erjiaqing
Copy link
Contributor

Problem

ReadSingleClusterData and WriteSingleClusterData is introduced quite early (~1yr ago) and ember is the only attribute storage at that time.

We have introduced many attribute backend, we can move some of the code out of ember-compatibility-functions.cpp for better test coverage (e.g. e2e test of attribute access interface, ACL etc.)
@erjiaqing erjiaqing mentioned this issue Jan 12, 2022
Merged
@mlepage-google mlepage-google mentioned this issue Jan 12, 2022
Open
@stale
Copy link

stale bot commented Jul 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 21, 2022
@stale
Copy link

stale bot commented Oct 18, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Stale issue or PR V1.X
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erjiaqing @woody-apple