Skip to content

Commit

Permalink
Fix thermostat feature map conformance for all-clusters app:
Browse files Browse the repository at this point in the history
1) Disable SCH bit, since we don't actually implement that in all-clusters-app.
2) Disable the attributes that were enabled for SCH.
3) Enable the mandatory SetPointRaiseLower command.

Fixes #19462
  • Loading branch information
bzbarsky-apple committed Jun 10, 2022
1 parent 287e47a commit c58d973
Show file tree
Hide file tree
Showing 4 changed files with 124 additions and 82 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3431,11 +3431,15 @@ server cluster Thermostat = 513 {
attribute access(write: manage) ThermostatControlSequence controlSequenceOfOperation = 27;
attribute access(write: manage) enum8 systemMode = 28;
readonly attribute enum8 thermostatRunningMode = 30;
readonly attribute enum8 startOfWeek = 32;
readonly attribute int8u numberOfWeeklyTransitions = 33;
readonly attribute int8u numberOfDailyTransitions = 34;
readonly attribute bitmap32 featureMap = 65532;
readonly attribute int16u clusterRevision = 65533;

request struct SetpointRaiseLowerRequest {
SetpointAdjustMode mode = 0;
INT8S amount = 1;
}

command SetpointRaiseLower(SetpointRaiseLowerRequest): DefaultSuccess = 0;
}

server cluster ThermostatUserInterfaceConfiguration = 516 {
Expand Down Expand Up @@ -4445,10 +4449,7 @@ endpoint 1 {
ram attribute controlSequenceOfOperation default = 0x04;
ram attribute systemMode default = 0x01;
ram attribute thermostatRunningMode;
ram attribute startOfWeek;
ram attribute numberOfWeeklyTransitions default = 7;
ram attribute numberOfDailyTransitions default = 4;
ram attribute featureMap default = 0x002b;
ram attribute featureMap default = 0x0023;
ram attribute clusterRevision default = 5;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14628,7 +14628,7 @@
"code": 0,
"mfgCode": null,
"source": "client",
"incoming": 0,
"incoming": 1,
"outgoing": 1
},
{
Expand Down Expand Up @@ -14971,7 +14971,7 @@
"mfgCode": null,
"side": "server",
"type": "enum8",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
Expand All @@ -14987,7 +14987,7 @@
"mfgCode": null,
"side": "server",
"type": "int8u",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
Expand All @@ -15003,7 +15003,7 @@
"mfgCode": null,
"side": "server",
"type": "int8u",
"included": 1,
"included": 0,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
Expand Down Expand Up @@ -15039,7 +15039,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x002b",
"defaultValue": "0x0023",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit c58d973

Please sign in to comment.