Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-sve] TC-TSTAT-1.1 Not available mandatory command #19462

Closed
mkleszcz-no opened this issue Jun 10, 2022 · 1 comment · Fixed by #19467
Closed

[pre-sve] TC-TSTAT-1.1 Not available mandatory command #19462

mkleszcz-no opened this issue Jun 10, 2022 · 1 comment · Fixed by #19467
Labels
cert blocker V1.0

Comments

@mkleszcz-no
Copy link

all-cluster-app
nrf52840dk
revison: 5d8599d

DUT has feature map 43 (101011) which means PICS_TSTAT_HEAT, PICS_TSTAT_COOL, PICS_TSTAT_SCH, PICS_TSTAT_AUTO.
Based on that information accepted command list should support commands 0, 1,2,3 (similar issue: #19158), but Accepted command list doesn't support any commands.

[1654867183.712261][80086:80091] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0201 Attribute 0x0000_FFFC DataVersion: 687561741
[1654867183.712276][80086:80091] CHIP:TOO:   FeatureMap: 43

[1654867193.426118][80110:80117] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0201 Attribute 0x0000_FFF9 DataVersion: 687561741
[1654867193.426145][80110:80117] CHIP:TOO:   AcceptedCommandList: 0 entries

logs:
TC_TSTAT_1_1_nRF.log
TC_TSTAT_1_1_nRF_DUT.log
@bzbarsky-apple
Copy link
Contributor

I don't think #19158 was resolved correctly. The whole point is we need to set up thermostat cluster in all-clusters-app in a way that is spec-compliant. That means either not having it at all, or disabling features it does not support, or implementing those features correctly.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 10, 2022
@bzbarsky-apple
Fix thermostat feature map conformance for all-clusters app:
ac9d6ec 
1) Disable SCH bit, since we don't actually implement that in all-clusters-app.
2) Disable the attributes that were enabled for SCH.
3) Enable the mandatory SetPointRaiseLower command.

Fixes project-chip#19462
@bzbarsky-apple bzbarsky-apple mentioned this issue Jun 10, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 10, 2022
@bzbarsky-apple
Fix thermostat feature map conformance for all-clusters app:
8887d07 
1) Disable SCH bit, since we don't actually implement that in all-clusters-app.
2) Disable the attributes that were enabled for SCH.
3) Enable the mandatory SetPointRaiseLower command.

Fixes project-chip#19462
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 10, 2022
@bzbarsky-apple
Fix thermostat feature map conformance for all-clusters app:
c58d973 
1) Disable SCH bit, since we don't actually implement that in all-clusters-app.
2) Disable the attributes that were enabled for SCH.
3) Enable the mandatory SetPointRaiseLower command.

Fixes project-chip#19462
andy31415 pushed a commit that referenced this issue Jun 13, 2022
@bzbarsky-apple
Fix thermostat feature map conformance for all-clusters app: (#19467)
6634d0c 
1) Disable SCH bit, since we don't actually implement that in all-clusters-app.
2) Disable the attributes that were enabled for SCH.
3) Enable the mandatory SetPointRaiseLower command.

Fixes #19462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cert blocker V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix thermostat feature map conformance for all-clusters app: bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @mkleszcz-no