Skip to content

Commit

Permalink
Add dishwasher alarm Reset feature to XML. (#28994)
Browse files Browse the repository at this point in the history
Fixes #28177
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Nov 2, 2023
1 parent a6c988e commit 921a843
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -2983,6 +2983,10 @@ server cluster DishwasherAlarm = 93 {
kWaterLevelError = 0x20;
}

bitmap Feature : BITMAP32 {
kReset = 0x1;
}

info event Notify = 0 {
AlarmMap active = 0;
AlarmMap inactive = 1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ bool DishwasherAlarmServer::HasResetFeature(EndpointId endpoint)
return false;
}

if (featureMap & 1)
if (featureMap & to_underlying(Feature::kReset))
{
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,9 @@ limitations under the License.
<field id="3" name="Mask" type="AlarmMap" />
</event>
</cluster>

<bitmap name="Feature" type="BITMAP32">
<cluster code="0x005D" />
<field name="Reset" mask="0x01" />
</bitmap>
</configurator>
4 changes: 4 additions & 0 deletions src/controller/data_model/controller-clusters.matter
Original file line number Diff line number Diff line change
Expand Up @@ -3306,6 +3306,10 @@ client cluster DishwasherAlarm = 93 {
kWaterLevelError = 0x20;
}

bitmap Feature : BITMAP32 {
kReset = 0x1;
}

info event Notify = 0 {
AlarmMap active = 0;
AlarmMap inactive = 1;
Expand Down
3 changes: 3 additions & 0 deletions src/controller/python/chip/clusters/Objects.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 921a843

Please sign in to comment.