Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DISHALM] It should be to_underlying(Feature::kReset) except we don't have that in our XML for some reason that escapes me. Please do this as a followup? #28177

Closed
rbultman opened this issue Jul 21, 2023 · 0 comments · Fixed by #28994
Closed

[DISHALM] It should be to_underlying(Feature::kReset) except we don't have that in our XML for some reason that escapes me. Please do this as a followup? #28177

rbultman opened this issue Jul 21, 2023 · 0 comments · Fixed by #28994
Labels
Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation v1.2

Comments

@rbultman
Copy link
Contributor 

          It should be `to_underlying(Feature::kReset)` except we don't have that in our XML for some reason that escapes me.  Please do this as a followup?

Originally posted by @bzbarsky-apple in #27748 (comment)
@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation Spec XML align SDK XML does not match the spec (including naming, etc) labels Jul 21, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Aug 31, 2023
@bzbarsky-apple
Add dishwasher alarm Reset feature to XML.
cd965f5 
Fixes project-chip#28177
@bzbarsky-apple bzbarsky-apple mentioned this issue Aug 31, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Aug 31, 2023
@bzbarsky-apple
Add dishwasher alarm Reset feature to XML.
320b3ae 
Fixes project-chip#28177
@mergify mergify bot closed this as completed in #28994 Sep 1, 2023
mergify bot pushed a commit that referenced this issue Sep 1, 2023
@bzbarsky-apple
Add dishwasher alarm Reset feature to XML. (#28994)
4064446 
Fixes #28177
abpoth pushed a commit to abpoth/connectedhomeip that referenced this issue Sep 12, 2023
@bzbarsky-apple @abpoth
Add dishwasher alarm Reset feature to XML. (project-chip#28994)
fd71559 
Fixes project-chip#28177
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Add dishwasher alarm Reset feature to XML. (project-chip#28994)
eff7ccc 
Fixes project-chip#28177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation v1.2
Projects
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dishwasher alarm Reset feature to XML. bzbarsky-apple/connectedhomeip
2 participants
@rbultman @bzbarsky-apple