Skip to content

Commit

Permalink
[chip-tool] Add flag to enable server interactions (#24695)
Browse files Browse the repository at this point in the history
Add "--advertise-operational" flag to the chip-tool's
"interactive" command that enables server features,
including advertising operational services. This feature
is needed to test persistent subscriptions using chip-tool,
which requires that chip-tool be discoverable after the
publisher node reboots.
  • Loading branch information
Damian-Nordic authored and pull[bot] committed Sep 5, 2023
1 parent 2681dd6 commit 7415193
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 1 deletion.
1 change: 1 addition & 0 deletions examples/chip-tool/commands/common/CHIPCommand.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ CHIP_ERROR CHIPCommand::MaybeSetUpStack()
factoryInitParams.fabricIndependentStorage = &mDefaultStorage;
factoryInitParams.operationalKeystore = &mOperationalKeystore;
factoryInitParams.opCertStore = &mOpCertStore;
factoryInitParams.enableServerInteractions = NeedsOperationalAdvertising();

// Init group data provider that will be used for all group keys and IPKs for the
// chip-tool-configured fabrics. This is OK to do once since the fabric tables
Expand Down
5 changes: 5 additions & 0 deletions examples/chip-tool/commands/common/CHIPCommand.h
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,11 @@ class CHIPCommand : public Command
// use member values that Shutdown will normally reset.
virtual bool DeferInteractiveCleanup() { return false; }

// If true, the controller will be created with server capabilities enabled,
// such as advertising operational nodes over DNS-SD and accepting incoming
// CASE sessions.
virtual bool NeedsOperationalAdvertising() { return false; }

// Execute any deferred cleanups. Used when exiting interactive mode.
static void ExecuteDeferredCleanups(intptr_t ignored);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,3 +276,8 @@ bool InteractiveCommand::ParseCommand(char * command, int * status)

return true;
}

bool InteractiveCommand::NeedsOperationalAdvertising()
{
return mAdvertiseOperational.ValueOr(true);
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,20 @@ class InteractiveCommand : public CHIPCommand
public:
InteractiveCommand(const char * name, Commands * commandsHandler, CredentialIssuerCommands * credsIssuerConfig) :
CHIPCommand(name, credsIssuerConfig), mHandler(commandsHandler)
{}
{
AddArgument("advertise-operational", 0, 1, &mAdvertiseOperational,
"Advertise operational node over DNS-SD and accept incoming CASE sessions.");
}

/////////// CHIPCommand Interface /////////
chip::System::Clock::Timeout GetWaitDuration() const override { return chip::System::Clock::Seconds16(0); }
bool NeedsOperationalAdvertising() override;

bool ParseCommand(char * command, int * status);

private:
Commands * mHandler = nullptr;
chip::Optional<bool> mAdvertiseOperational;
};

class InteractiveStartCommand : public InteractiveCommand
Expand Down

0 comments on commit 7415193

Please sign in to comment.