-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add flag to enable server interactions #24695
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
Damian-Nordic:server-interactions
Jan 30, 2023
Merged
[chip-tool] Add flag to enable server interactions #24695
yufengwangca
merged 1 commit into
project-chip:master
from
Damian-Nordic:server-interactions
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google and
mrjerryjohns
January 27, 2023 11:14
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 27, 2023 11:14
pullapprove
bot
added
review - pending
examples
tools
and removed
tools
examples
labels
Jan 27, 2023
PR #24695: Size comparison from 4820cbd to b3ed134 Increases (11 builds for bl602, cyw30739, linux, psoc6, qpg, telink)
Decreases (5 builds for esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
force-pushed
the
server-interactions
branch
from
January 27, 2023 21:07
b3ed134
to
f5678d1
Compare
PR #24695: Size comparison from 42d0ac8 to f5678d1 Increases above 0.2%:
Increases (9 builds for bl702, esp32, linux, nrfconnect, psoc6, qpg)
Decreases (4 builds for bl602, esp32, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 28, 2023
Add "--advertise-operational" flag to the chip-tool's "interactive" command that enables server features, including advertising operational services. This feature is needed to test persistent subscriptions using chip-tool, which requires that chip-tool be discoverable after the publisher node reboots.
Damian-Nordic
force-pushed
the
server-interactions
branch
from
January 30, 2023 09:54
f5678d1
to
74ae7b8
Compare
PR #24695: Size comparison from 4f24db4 to 74ae7b8 Increases above 0.2%:
Increases (10 builds for bl602, bl702, linux, psoc6, telink)
Decreases (3 builds for bl702, esp32, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jan 30, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Add "--advertise-operational" flag to the chip-tool's "interactive" command that enables server features, including advertising operational services. This feature is needed to test persistent subscriptions using chip-tool, which requires that chip-tool be discoverable after the publisher node reboots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "--advertise-operational" flag to the chip-tool's
"interactive start" command that enables server features,
including advertising operational services. This feature
is needed to test persistent subscriptions using chip-tool,
which requires that chip-tool be discoverable after the
publisher node reboots.