Skip to content

Commit

Permalink
Fix ColorCapabilities value mismatch with featuremap (#19825)
Browse files Browse the repository at this point in the history
* Update ColorCapabilities to the same value than the featuremap's

* regen

* update test TC_CC_2_1

* rebase n regen
  • Loading branch information
jmartinez-silabs authored and pull[bot] committed Jul 21, 2022
1 parent 815f077 commit 62a53f5
Show file tree
Hide file tree
Showing 12 changed files with 364 additions and 313 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4460,7 +4460,7 @@ endpoint 1 {
ram attribute colorLoopTime default = 0x0019;
ram attribute colorLoopStartEnhancedHue default = 0x2300;
ram attribute colorLoopStoredEnhancedHue;
ram attribute colorCapabilities;
ram attribute colorCapabilities default = 0x1F;
ram attribute colorTempPhysicalMinMireds;
ram attribute colorTempPhysicalMaxMireds default = 0xFEFF;
ram attribute coupleColorTempToLevelMinMireds;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16425,7 +16425,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0000",
"defaultValue": "0x1F",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3634,7 +3634,7 @@ endpoint 1 {
ram attribute options;
ram attribute numberOfPrimaries;
ram attribute enhancedColorMode default = 0x01;
ram attribute colorCapabilities;
ram attribute colorCapabilities default = 0x1F;
ram attribute featureMap;
ram attribute clusterRevision default = 5;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16281,7 +16281,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0000",
"defaultValue": "0x1F",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
Expand Down
2 changes: 1 addition & 1 deletion examples/lighting-app/lighting-common/lighting-app.matter
Original file line number Diff line number Diff line change
Expand Up @@ -2016,7 +2016,7 @@ endpoint 1 {
ram attribute colorLoopTime default = 0x0019;
ram attribute colorLoopStartEnhancedHue default = 0x2300;
ram attribute colorLoopStoredEnhancedHue;
ram attribute colorCapabilities;
ram attribute colorCapabilities default = 0x1F;
ram attribute colorTempPhysicalMinMireds;
ram attribute colorTempPhysicalMaxMireds default = 0xFEFF;
ram attribute coupleColorTempToLevelMinMireds;
Expand Down
2 changes: 1 addition & 1 deletion examples/lighting-app/lighting-common/lighting-app.zap
Original file line number Diff line number Diff line change
Expand Up @@ -7947,7 +7947,7 @@
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x0000",
"defaultValue": "0x1F",
"reportable": 1,
"minInterval": 0,
"maxInterval": 65344,
Expand Down
8 changes: 7 additions & 1 deletion src/app/tests/suites/certification/Test_TC_CC_2_1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,18 @@ tests:
constraints:
type: uint16

- label: "read the optional global attribute: FeatureMap"
command: "readAttribute"
attribute: "FeatureMap"
response:
saveAs: FeatureMapValue

- label: "Reads ColorCapabilities attribute from DUT"
PICS: CC.S.A400a
command: "readAttribute"
attribute: "ColorCapabilities"
response:
value: 0
value: FeatureMapValue

- label: "Validate constraints of attribute: ColorCapabilities"
PICS: CC.S.A400a
Expand Down
24 changes: 12 additions & 12 deletions zzz_generated/all-clusters-app/zap-generated/endpoint_config.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 62a53f5

Please sign in to comment.