Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ColorCapabilities value mismatch with featuremap #19825

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Fix ColorCapabilities value mismatch with featuremap #19825

merged 4 commits into from
Jun 22, 2022

Conversation

jmartinez-silabs
Copy link
Member

@jmartinez-silabs jmartinez-silabs commented Jun 21, 2022 •
edited
Loading

Problem

fixes #19791

Change overview

Set color capabilities to match the feature map value
Update test CC 2.1 to compare feature map value to the ColorCapabilites attribute

Testing

TEST_TC_CC_2_1

@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

PR #19825: Size comparison from 19a6269 to 70958a5

Increases (1 build for linux)
platform target config section 19a6269 70958a5 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9887356 9887628 272 0.0
.rodata 473180 473196 16 0.0
.text 7877748 7878004 256 0.0
Decreases (2 builds for efr32, telink)
platform target config section 19a6269 70958a5 change % change
efr32 lock-app BRD4161A+wf200 (read only) 967144 967128 -16 -0.0
.text 967136 967120 -16 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 790480 790472 -8 -0.0
text 560394 560392 -2 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 19a6269 70958a5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660135 660135 0 0.0
(read/write) 190736 190736 0 0.0
.bss 73764 73764 0 0.0
.data 3356 3356 0 0.0
.rodata 87239 87239 0 0.0
.text 572584 572584 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 648947 648947 0 0.0
(read/write) 157324 157324 0 0.0
.bss 73052 73052 0 0.0
.data 3356 3356 0 0.0
.rodata 90771 90771 0 0.0
.text 557856 557856 0 0.0
lock-ftd LP_CC2652R7 (read only) 691535 691535 0 0.0
(read/write) 149448 149448 0 0.0
.bss 70764 70764 0 0.0
.data 3280 3280 0 0.0
.rodata 99551 99551 0 0.0
.text 591500 591500 0 0.0
lock-mtd LP_CC2652R7 (read only) 640951 640951 0 0.0
(read/write) 143896 143896 0 0.0
.bss 66500 66500 0 0.0
.data 3280 3280 0 0.0
.rodata 99431 99431 0 0.0
.text 541028 541028 0 0.0
pump-app LP_CC2652R7 (read only) 672799 672799 0 0.0
(read/write) 169072 169072 0 0.0
.bss 70884 70884 0 0.0
.data 3280 3280 0 0.0
.rodata 87903 87903 0 0.0
.text 584412 584412 0 0.0
pump-controller-app LP_CC2652R7 (read only) 658675 658675 0 0.0
(read/write) 183308 183308 0 0.0
.bss 70996 70996 0 0.0
.data 3276 3276 0 0.0
.rodata 83747 83747 0 0.0
.text 574448 574448 0 0.0
shell LP_CC2652R7 (read only) 689870 689870 0 0.0
(read/write) 156496 156496 0 0.0
.bss 76060 76060 0 0.0
.data 3360 3360 0 0.0
.rodata 110022 110022 0 0.0
.text 579536 579536 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 613246 613246 0 0.0
.app_xip_area 469896 469896 0 0.0
.bss 86304 86304 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610626 610626 0 0.0
.app_xip_area 467100 467100 0 0.0
.bss 86480 86480 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 617134 617134 0 0.0
.app_xip_area 474672 474672 0 0.0
.bss 85472 85472 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 925456 925456 0 0.0
(read/write) 132424 132424 0 0.0
.bss 130344 130344 0 0.0
.data 2080 2080 0 0.0
.text 925448 925448 0 0.0
BRD4161A+rpc (read only) 961160 961160 0 0.0
(read/write) 149304 149304 0 0.0
.bss 147016 147016 0 0.0
.data 2284 2284 0 0.0
.text 961152 961152 0 0.0
BRD4161A+rs911x (read only) 800804 800804 0 0.0
(read/write) 128700 128700 0 0.0
.bss 126612 126612 0 0.0
.data 2088 2088 0 0.0
.text 800796 800796 0 0.0
lock-app BRD4161A+wf200 (read only) 967144 967128 -16 -0.0
(read/write) 129076 129076 0 0.0
.bss 126988 126988 0 0.0
.data 2088 2088 0 0.0
.text 967136 967120 -16 -0.0
window-app BRD4161A (read only) 910600 910600 0 0.0
(read/write) 132528 132528 0 0.0
.bss 130416 130416 0 0.0
.data 2108 2108 0 0.0
.text 910592 910592 0 0.0
esp32 all-clusters-app c3devkit (read only) 1013698 1013698 0 0.0
(read/write) 1483554 1483554 0 0.0
.dram0.bss 69400 69400 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214080 214080 0 0.0
.flash.text 1013698 1013698 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068163 1068163 0 0.0
(read/write) 485640 485640 0 0.0
.dram0.bss 74920 74920 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244580 244580 0 0.0
.flash.text 1062779 1062779 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659604 659604 0 0.0
.bss 68764 68764 0 0.0
.data 1992 1992 0 0.0
.text 583048 583048 0 0.0
lock k32w061+release (read/write) 722156 722156 0 0.0
.bss 69204 69204 0 0.0
.data 2000 2000 0 0.0
.text 645152 645152 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9887356 9887628 272 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473180 473196 16 0.0
.text 7877748 7878004 256 0.0
thermostat-no-ble arm64 (read only) 2575988 2575988 0 0.0
(read/write) 180577 180577 0 0.0
.bss 87889 87889 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164196 164196 0 0.0
.text 2172720 2172720 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439072 2439072 0 0.0
.bss 208212 208212 0 0.0
.data 5864 5864 0 0.0
.text 1401716 1401716 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199911 1199911 0 0.0
bss 141606 141606 0 0.0
rodata 156312 156312 0 0.0
text 823092 823092 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1147887 1147887 0 0.0
bss 140858 140858 0 0.0
rodata 132840 132840 0 0.0
text 795316 795316 0 0.0
p6 all-clusters-app default (read/write) 2555392 2555392 0 0.0
.bss 143392 143392 0 0.0
.data 2776 2776 0 0.0
.text 1513656 1513656 0 0.0
all-clusters-minimal-app default (read/write) 2501240 2501240 0 0.0
.bss 142672 142672 0 0.0
.data 2776 2776 0 0.0
.text 1459504 1459504 0 0.0
light-app default (read/write) 2432000 2432000 0 0.0
.bss 134752 134752 0 0.0
.data 2592 2592 0 0.0
.text 1390264 1390264 0 0.0
lock-app default (read/write) 2452712 2452712 0 0.0
.bss 134576 134576 0 0.0
.data 2600 2600 0 0.0
.text 1410976 1410976 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790480 790472 -8 -0.0
bss 69900 69900 0 0.0
noinit 40416 40416 0 0.0
text 560394 560392 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 810184 810184 0 0.0
bss 70148 70148 0 0.0
noinit 40416 40416 0 0.0
text 576854 576854 0 0.0

@github-actions
Copy link

github-actions bot commented Jun 22, 2022 •
edited
Loading

PR #19825: Size comparison from d1a4bb7 to 241dc31

Increases (3 builds for cc13x2_26x2, esp32, linux)
platform target config section d1a4bb7 241dc31 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 183604 183612 8 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014136 2 0.0
.flash.text 1014134 1014136 2 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9925180 9925468 288 0.0
.rodata 473916 473932 16 0.0
.text 7910292 7910564 272 0.0
Decreases (3 builds for cc13x2_26x2, nrfconnect, telink)
platform target config section d1a4bb7 241dc31 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 659123 659115 -8 -0.0
.text 575136 575128 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 823984 823980 -4 -0.0
telink light-switch-app tlsr9518adk80d text 561060 561058 -2 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d1a4bb7 241dc31 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660439 660439 0 0.0
(read/write) 191168 191168 0 0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 86975 86975 0 0.0
.text 573152 573152 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649251 649251 0 0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90507 90507 0 0.0
.text 558424 558424 0 0.0
lock-ftd LP_CC2652R7 (read only) 691999 691999 0 0.0
(read/write) 149720 149720 0 0.0
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99351 0 0.0
.text 592164 592164 0 0.0
lock-mtd LP_CC2652R7 (read only) 641415 641415 0 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99239 99239 0 0.0
.text 541684 541684 0 0.0
pump-app LP_CC2652R7 (read only) 673231 673231 0 0.0
(read/write) 169384 169384 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87663 87663 0 0.0
.text 585084 585084 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659123 659115 -8 -0.0
(read/write) 183604 183612 8 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83507 83507 0 0.0
.text 575136 575128 -8 -0.0
shell LP_CC2652R7 (read only) 690198 690198 0 0.0
(read/write) 156912 156912 0 0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109758 109758 0 0.0
.text 580128 580128 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591730 0 0.0
.app_xip_area 462628 462628 0 0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589106 589106 0 0.0
.app_xip_area 459828 459828 0 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594250 0 0.0
.app_xip_area 466020 466020 0 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926072 926072 0 0.0
(read/write) 133664 133664 0 0.0
.bss 131584 131584 0 0.0
.data 2080 2080 0 0.0
.text 926064 926064 0 0.0
BRD4161A+rpc (read only) 963216 963216 0 0.0
(read/write) 150552 150552 0 0.0
.bss 148264 148264 0 0.0
.data 2284 2284 0 0.0
.text 963208 963208 0 0.0
BRD4161A+rs911x (read only) 802580 802580 0 0.0
(read/write) 140316 140316 0 0.0
.bss 138228 138228 0 0.0
.data 2088 2088 0 0.0
.text 802572 802572 0 0.0
lock-app BRD4161A+wf200 (read only) 968288 968288 0 0.0
(read/write) 140692 140692 0 0.0
.bss 138604 138604 0 0.0
.data 2088 2088 0 0.0
.text 968280 968280 0 0.0
window-app BRD4161A (read only) 911240 911240 0 0.0
(read/write) 133768 133768 0 0.0
.bss 131656 131656 0 0.0
.data 2108 2108 0 0.0
.text 911232 911232 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014136 2 0.0
(read/write) 1484770 1484770 0 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214064 214064 0 0.0
.flash.text 1014134 1014136 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068459 1068459 0 0.0
(read/write) 486856 486856 0 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244564 244564 0 0.0
.flash.text 1063075 1063075 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661524 661524 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 583976 583976 0 0.0
lock k32w061+release (read/write) 723452 723452 0 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645448 645448 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9925180 9925468 288 0.0
(read/write) 676161 676161 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615080 615080 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473916 473932 16 0.0
.text 7910292 7910564 272 0.0
thermostat-no-ble arm64 (read only) 2578364 2578364 0 0.0
(read/write) 180609 180609 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82896 82896 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164540 164540 0 0.0
.text 2174752 2174752 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439432 2439432 0 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402076 1402076 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201883 1201883 0 0.0
bss 142862 142862 0 0.0
rodata 156108 156108 0 0.0
text 823984 823980 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149639 0 0.0
bss 142098 142098 0 0.0
rodata 132592 132592 0 0.0
text 796032 796032 0 0.0
p6 all-clusters-app default (read/write) 2555776 2555776 0 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514040 1514040 0 0.0
all-clusters-minimal-app default (read/write) 2501624 2501624 0 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1459888 1459888 0 0.0
light-app default (read/write) 2432384 2432384 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390648 1390648 0 0.0
lock-app default (read/write) 2453096 2453096 0 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411360 1411360 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792080 792080 0 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561060 561058 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 811784 811784 0 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577520 577520 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit 756e3ab into project-chip:master Jun 22, 2022
@jmartinez-silabs jmartinez-silabs deleted the fix_colorcapabilities branch June 22, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
4 participants
@jmartinez-silabs @andy31415 @woody-apple @bzbarsky-apple