-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix CommissioningWindowManager DNS UDP leak (#11983)
#### Problem `chip::Server::Shutdown()` contains ``` chip::Dnssd::ServiceAdvertiser::Instance().Shutdown(); ⋮ mCommissioningWindowManager.Cleanup(); ``` but the latter restarts `Dnssd::ServiceAdvertiser`. Instance of #11880 _Possible use of destroyed pool objects_ #### Change overview Add `CommissioningWindowManager::Shutdown()` which does not restart DNS. #### Testing If `ObjectPool` checks that objects do not outlive it (originally part of PR #11698 but deferred due to current leaks), then `TestCommissionManager` fails without this change.
- Loading branch information
1 parent
c12484e
commit 1534492
Showing
4 changed files
with
10 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters