Skip to content

Commit

Permalink
Remove incorrect comments in WriteHandler. (#17606)
Browse files Browse the repository at this point in the history
We're not parsing into a "cluster info" and we are not ignoring
CHIP_END_OF_TLV.  The comments simply do not match the code.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Aug 9, 2023
1 parent d4b1b2d commit 1453266
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/app/WriteHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,6 @@ CHIP_ERROR WriteHandler::ProcessAttributeDataIBs(TLV::TLVReader & aAttributeData
err = element.GetPath(&attributePath);
SuccessOrExit(err);

// We are using the feature that the parser won't touch the value if the field does not exist, since all fields in the
// cluster info will be invalid / wildcard, it is safe ignore CHIP_END_OF_TLV directly.

err = attributePath.GetEndpoint(&(dataAttributePath.mEndpointId));
SuccessOrExit(err);

Expand Down Expand Up @@ -424,9 +421,6 @@ CHIP_ERROR WriteHandler::ProcessGroupAttributeDataIBs(TLV::TLVReader & aAttribut
err = element.GetPath(&attributePath);
SuccessOrExit(err);

// We are using the feature that the parser won't touch the value if the field does not exist, since all fields in the
// cluster info will be invalid / wildcard, it is safe to ignore CHIP_END_OF_TLV.

err = attributePath.GetCluster(&(dataAttributePath.mClusterId));
SuccessOrExit(err);

Expand Down

0 comments on commit 1453266

Please sign in to comment.