Skip to content

Commit

Permalink
[Hotfix] disable lcd in CI lighting_app with RPC build (#22052)
Browse files Browse the repository at this point in the history
* Hotfix, disable lcd in CI lighting_app with RPC build

* oops disable_lcd=true

* missing #ifdef for building without lcd + add is_debug=false for efr32 rpc builds when using build_examples.py

* fix strings in build_all_except_host.txt

* fix strings again in build_all_except_host.txt
  • Loading branch information
jmartinez-silabs authored and pull[bot] committed Jan 10, 2024
1 parent ffe1f39 commit 1245235
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 34 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/examples-efr32.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
timeout-minutes: 15
run: |
scripts/examples/gn_efr32_example.sh examples/lighting-app/efr32/ out/lighting_app_debug_rpc BRD4161A "is_debug=false" \
'import("//with_pw_rpc.gni")'
disable_lcd=true 'import("//with_pw_rpc.gni")'
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py efr32 BRD4161A+rpc lighting-app \
out/lighting_app_debug_rpc/BRD4161A/chip-efr32-lighting-example.out /tmp/bloat_reports/
- name: Build example EFR32+WF200 WiFi Lock app for BRD4161A
Expand Down
2 changes: 2 additions & 0 deletions examples/platform/efr32/BaseApplication.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,10 @@ void BaseApplication::ButtonHandler(AppEvent * aEvent)
CancelFunctionTimer();
mFunction = kFunction_NoneSelected;

#ifdef DISPLAY_ENABLED
// TOGGLE QRCode/LCD demo UI
slLCD.ToggleQRCode();
#endif

#ifdef SL_WIFI
if (!ConnectivityMgr().IsWiFiStationProvisioned())
Expand Down
2 changes: 1 addition & 1 deletion scripts/build/builders/efr32.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def __init__(self,
self.extra_gn_options = ['efr32_board="%s"' % board.GnArgName()]

if enable_rpcs:
self.extra_gn_options.append('import("//with_pw_rpc.gni")')
self.extra_gn_options.append('is_debug=false import("//with_pw_rpc.gni")')

if enable_ota_requestor:
self.extra_gn_options.append('chip_enable_ota_requestor=true')
Expand Down
Loading

0 comments on commit 1245235

Please sign in to comment.