feat: OpenTelemetry intrumentation #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed #12 - [x] Bootstrap opentelemetry - [x] By default export json - [x] Root trace is the cmd.Execute - [x] One span for every goroutine (measure concurrency) * - [ ] Allow to export to collector (blocked by open-telemetry/opentelemetry-go#497) - [ ] Find a way to trace kubernetes client-go - [ ] Trace http.Client that makes requests to profefe API * In order to get the gathering of the profile efficient I use a channel that spread the work across many goroutine (atm fixed to 10). The root span has a child for any goroutine. Signed-off-by: Gianluca Arbezzano <[email protected]>
gianarb
added
the
kprofefe
xrmx
reviewed
Mar 10, 2020
pkg/cmd/kprofefe.go
Outdated
| wg.Done() | ||
| return | ||
| if err != nil { | ||
| logger.Fatal("Impossible to retrive a kubernetes config", zap.Error(err)) |
gianarb
force-pushed
the
feature/poc-opentelemetry
branch
from
4384678 to
0f01b32
Compare
Signed-off-by: Gianluca Arbezzano <[email protected]>
gianarb
added a commit
that referenced
this pull request
Mar 11, 2020
feat: OpenTelemetry intrumentation Signed-off-by: Gianluca Arbezzano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #12
opentelemetry collector trace exporter open-telemetry/opentelemetry-go#497)
In order to gather all the profiles efficiently, I use a channel
that spreads the work across many goroutines (atm fixed to 10). The root
span has a child for any goroutine.
Signed-off-by: Gianluca Arbezzano [email protected]