Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor kprofefe with opentelemetry #12

Closed
gianarb opened this issue Dec 7, 2019 · 0 comments · Fixed by #29
Closed

Monitor kprofefe with opentelemetry #12

gianarb opened this issue Dec 7, 2019 · 0 comments · Fixed by #29
Labels
kprofefe It is in the continuous collector and kprofefe binary space

Comments

@gianarb
Copy link
Member

gianarb commented Dec 7, 2019

We should figure out if it is useful to get aggregated metrics from kprofefe (probably yes, I would like to be notified if we stop collecting profiles for some reason).

OpenTelemetry is probably the way to go those days
@gianarb gianarb added the kprofefe It is in the continuous collector and kprofefe binary space label Dec 7, 2019
gianarb pushed a commit that referenced this issue Mar 6, 2020
feat: OpenTelemetry intrumentation
efcf190 
Fixed #12

- [x] Bootstrap opentelemetry
- [x] By default export json
- [x] Root trace is the cmd.Execute
- [x] One span for every goroutine (measure concurrency) *
- [ ] Allow to export to collector (blocked by
open-telemetry/opentelemetry-go#497)
- [ ] Find a way to trace kubernetes client-go
- [ ] Trace http.Client that makes requests to profefe API

* In order to get the gathering of the profile efficient I use a channel
that spread the work across many goroutine (atm fixed to 10). The root
span has a child for any goroutine.

Signed-off-by: Gianluca Arbezzano <[email protected]>
@gianarb gianarb mentioned this issue Mar 6, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kprofefe It is in the continuous collector and kprofefe binary space
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: OpenTelemetry intrumentation profefe/kube-profefe
1 participant
@gianarb