-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build base classes and visitors for custom shapes in p5.js 2.0 #7373
Draft
GregStanton
wants to merge
43
commits into
processing:dev-2.0
Choose a base branch
from
GregStanton:dev-2.0
base: dev-2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
62567a9
commit message
GregStanton 2107ecb
Add custom_shapes.js to eventually replace vertex.js
GregStanton e38b3b9
Set up files for custom shape refactor
GregStanton cff8461
Merge branch 'dev-2.0' of https://github.com/processing/p5.js into de…
GregStanton b778784
Add inline documentation for Shape class
GregStanton 19e8c48
Fix documentation of default parameter for Shape constructor
GregStanton 8eb74e6
Update inline documentation for p5.Shape
GregStanton f0fc908
Document p5.Vertex
GregStanton 1a05d51
Fix code snippet in p5.Vertex documentation
GregStanton 45591b0
Revise p5.Vertex documentation and add todo comment about a new imple…
GregStanton 37c2db4
Move TODO comments out of the code (and into project timeline)
GregStanton 9663eda
Document p5.Contour
GregStanton 5cd71a2
Document p5.ShapePrimitive (and revise some other documentation).
GregStanton 84a0fde
Revise docs for clarity.
GregStanton 0b117cc
Add TODO comment about Vertex interface
GregStanton 2fcc2b0
Describe custom vertex properties in Shape docs
GregStanton d862591
Revise p5.Contour docs based on new design
GregStanton 8ea67c5
Remove @constructor tags (YUIDoc syntax)
GregStanton 1443b53
Fix typo in Shape docs
GregStanton 78940ff
Update p5.ShapePrimitive docs with new design
GregStanton 4dac39e
Update p5.Vertex docs to reflect new design
GregStanton 567ff25
Make p5.Vertex and p5.Shape constructors consistent
GregStanton dbff7a2
Merge branch 'dev-2.0' of https://github.com/processing/p5.js into de…
GregStanton 727ff60
Move fill and stroke into the base renderer
davepagurek c756172
Add vertex state getter
davepagurek b4e43e5
Fix usage of false instead of null
davepagurek 64e319b
Add properties to current shape
davepagurek 290f5c7
Update vertexProperties to make setters
davepagurek cd156bf
Refactor old vertex() into legacyVertex() and start making new vertex()
davepagurek bc252e3
Implement Vertex constructor
GregStanton 0c61aaf
Implement ShapePrimitive, add some doc tags
GregStanton 2326ff5
Add PATH to constants.js
GregStanton 75030a5
Implement Contour
GregStanton 70a6fa6
Add EMPTY_PATH to constants.js
GregStanton d7aec76
Add kind getter to Contour to handle EMPTY_PATH
GregStanton 27f0b26
Add tag to Anchor docs
GregStanton 4eaa56f
Implement Anchor, add vertices to ShapePrimitive
GregStanton 13f21d9
Implement Segment, add tags to docs
GregStanton 787ca3c
Implement addToShape on ShapePrimitive (base class)
GregStanton dbf64f6
Changed initial value of index in Segment
GregStanton 65c2d32
Add note in Segment docs
GregStanton 20922c7
Move index out of base Segment class
GregStanton 9468d2e
Add at() method on Shape, revise Segment & Anchor, implement LineSegm…
GregStanton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davepagurek Does this look okay? I remembered from the 2.0 RFC that the plan is to use
Symbol
when the underlying value of a constant isn't needed. I'm guessing we just haven't gotten around to changing all the constants that fit that description?Update: I added both
PATH
andEMPTY_PATH
as Symbol values.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so!