Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build base classes and visitors for custom shapes in p5.js 2.0 #7373

Draft
wants to merge 57 commits into
base: dev-2.0
Choose a base branch
from
Draft

Build base classes and visitors for custom shapes in p5.js 2.0 #7373

wants to merge 57 commits into from

Commits on Nov 9, 2024

  1. commit message

    @GregStanton
    GregStanton committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    62567a9 View commit details
    Browse the repository at this point in the history

  2. Add custom_shapes.js to eventually replace vertex.js

    @GregStanton
    GregStanton committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    2107ecb View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Set up files for custom shape refactor

    @GregStanton
    GregStanton committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    e38b3b9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev-2.0' of https://github.com/processing/p5.js into de… 

    …v-2.0
    @GregStanton
    GregStanton committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    cff8461 View commit details
    Browse the repository at this point in the history

  3. Add inline documentation for Shape class

    @GregStanton
    GregStanton committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b778784 View commit details
    Browse the repository at this point in the history

  4. Fix documentation of default parameter for Shape constructor

    @GregStanton
    GregStanton committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    19e8c48 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Update inline documentation for p5.Shape

    @GregStanton
    GregStanton committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8eb74e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Document p5.Vertex

    @GregStanton
    GregStanton committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f0fc908 View commit details
    Browse the repository at this point in the history

  2. Fix code snippet in p5.Vertex documentation

    @GregStanton
    GregStanton committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1a05d51 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Revise p5.Vertex documentation and add todo comment about a new imple… 

    …mentation
    @GregStanton
    GregStanton committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    45591b0 View commit details
    Browse the repository at this point in the history

  2. Move TODO comments out of the code (and into project timeline)

    @GregStanton
    GregStanton committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    37c2db4 View commit details
    Browse the repository at this point in the history

  3. Document p5.Contour

    @GregStanton
    GregStanton committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9663eda View commit details
    Browse the repository at this point in the history

  4. Document p5.ShapePrimitive (and revise some other documentation).

    @GregStanton
    GregStanton committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5cd71a2 View commit details
    Browse the repository at this point in the history

  5. Revise docs for clarity.

    @GregStanton
    GregStanton committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    84a0fde View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Add TODO comment about Vertex interface

    @GregStanton
    GregStanton committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    0b117cc View commit details
    Browse the repository at this point in the history

  2. Describe custom vertex properties in Shape docs

    @GregStanton
    GregStanton committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2fcc2b0 View commit details
    Browse the repository at this point in the history

  3. Revise p5.Contour docs based on new design

    @GregStanton
    GregStanton committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d862591 View commit details
    Browse the repository at this point in the history

  4. Remove @constructor tags (YUIDoc syntax)

    @GregStanton
    GregStanton committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    8ea67c5 View commit details
    Browse the repository at this point in the history

  5. Fix typo in Shape docs

    @GregStanton
    GregStanton committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1443b53 View commit details
    Browse the repository at this point in the history

  6. Update p5.ShapePrimitive docs with new design

    @GregStanton
    GregStanton committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    78940ff View commit details
    Browse the repository at this point in the history

  7. Update p5.Vertex docs to reflect new design

    @GregStanton
    GregStanton committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4dac39e View commit details
    Browse the repository at this point in the history

  8. Make p5.Vertex and p5.Shape constructors consistent

    @GregStanton
    GregStanton committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    567ff25 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'dev-2.0' of https://github.com/processing/p5.js into de… 

    …v-2.0

Updating my local repo before pushing to origin.
    @GregStanton
    GregStanton committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    dbff7a2 View commit details
    Browse the repository at this point in the history

  10. Move fill and stroke into the base renderer

    @davepagurek
    davepagurek committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    727ff60 View commit details
    Browse the repository at this point in the history

  11. Add vertex state getter

    @davepagurek
    davepagurek committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    c756172 View commit details
    Browse the repository at this point in the history

  12. Fix usage of false instead of null

    @davepagurek
    davepagurek committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b4e43e5 View commit details
    Browse the repository at this point in the history

  13. Add properties to current shape

    @davepagurek
    davepagurek committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    64e319b View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Update vertexProperties to make setters

    @davepagurek
    davepagurek committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    290f5c7 View commit details
    Browse the repository at this point in the history

  2. Refactor old vertex() into legacyVertex() and start making new vertex()

    @davepagurek
    davepagurek committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    cd156bf View commit details
    Browse the repository at this point in the history

  3. Implement Vertex constructor

    @GregStanton
    GregStanton committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    bc252e3 View commit details
    Browse the repository at this point in the history

  4. Implement ShapePrimitive, add some doc tags

    @GregStanton
    GregStanton committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    0c61aaf View commit details
    Browse the repository at this point in the history

  5. Add PATH to constants.js

    @GregStanton
    GregStanton committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    2326ff5 View commit details
    Browse the repository at this point in the history

  6. Implement Contour

    @GregStanton
    GregStanton committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    75030a5 View commit details
    Browse the repository at this point in the history

  7. Add EMPTY_PATH to constants.js

    @GregStanton
    GregStanton committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    70a6fa6 View commit details
    Browse the repository at this point in the history

  8. Add kind getter to Contour to handle EMPTY_PATH

    @GregStanton
    GregStanton committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    d7aec76 View commit details
    Browse the repository at this point in the history

  9. Add tag to Anchor docs

    @GregStanton
    GregStanton committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    27f0b26 View commit details
    Browse the repository at this point in the history

  10. Implement Anchor, add vertices to ShapePrimitive

    @GregStanton
    GregStanton committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    4eaa56f View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2024

  1. Implement Segment, add tags to docs

    @GregStanton
    GregStanton committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    13f21d9 View commit details
    Browse the repository at this point in the history

  2. Implement addToShape on ShapePrimitive (base class)

    @GregStanton
    GregStanton committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    787ca3c View commit details
    Browse the repository at this point in the history

  3. Changed initial value of index in Segment

    @GregStanton
    GregStanton committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    dbf64f6 View commit details
    Browse the repository at this point in the history

  4. Add note in Segment docs

    @GregStanton
    GregStanton committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    65c2d32 View commit details
    Browse the repository at this point in the history

  5. Move index out of base Segment class

    @GregStanton
    GregStanton committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    20922c7 View commit details
    Browse the repository at this point in the history

  6. Add at() method on Shape, revise Segment & Anchor, implement LineSegm… 

    …ent, plus small changes
    @GregStanton
    GregStanton committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    9468d2e View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Merge branch 'dev-2.0' of https://github.com/processing/p5.js into de… 

    …v-2.0

Updating my local repo.
    @GregStanton
    GregStanton committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    13b0519 View commit details
    Browse the repository at this point in the history

  2. Implement all custom shape constants as Symbols

    @GregStanton
    GregStanton committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    6adb65a View commit details
    Browse the repository at this point in the history

  3. Implement PrimitiveShapeCreators

    @GregStanton
    GregStanton committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    ee77b1c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Set all custom shape constants to numbers (for now)

    @GregStanton
    GregStanton committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    b6aec19 View commit details
    Browse the repository at this point in the history

  2. Make PrimitiveShapeCreators work with number constants instead of Sym… 

    …bols (for now)
    @GregStanton
    GregStanton committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    69ed953 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev-2.0' of https://github.com/processing/p5.js into de… 

    …v-2.0

Updating local repo
    @GregStanton
    GregStanton committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    893c897 View commit details
    Browse the repository at this point in the history

  4. Implement beginShape(), endShape() on Shape and update docs

    @GregStanton
    GregStanton committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    60739f0 View commit details
    Browse the repository at this point in the history

  5. Implement vertex() on Shape, refactor, fix bugs

    @GregStanton
    GregStanton committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    15001d9 View commit details
    Browse the repository at this point in the history

  6. Fix spacing

    @GregStanton
    GregStanton committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    e862092 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Implement abstract base class PrimitiveVisitor

    @GregStanton
    GregStanton committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    722125b View commit details
    Browse the repository at this point in the history

  2. Add anchor visitor method to base class

    @GregStanton
    GregStanton committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    4fd0458 View commit details
    Browse the repository at this point in the history

  3. Implement PrimitiveToPath2DConverter with anchor and line segment vis… 

    …itor methods only
    @GregStanton
    GregStanton committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    18a2e6c View commit details
    Browse the repository at this point in the history

  4. Use only new rendering code and start connecting visitors

    @davepagurek
    davepagurek committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    a42fb19 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2024

  1. Initial WebGL tesselation support

    @davepagurek
    davepagurek committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    49be169 View commit details
    Browse the repository at this point in the history