Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] fix proportions for zoom in and zoom out coherence #832

Merged
merged 5 commits into from
Oct 28, 2020

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Oct 26, 2020

Ensure that doing zoom in then zoom out (or the opposite) restore the initial zoom factor.

@aibcmars aibcmars added the enhancement New feature or request label Oct 26, 2020
@tbouffard tbouffard changed the title [FEAT] fix proportions for zoom_in zoom_out coherence [FEAT] fix proportions for zoom in and zoom out coherence Oct 26, 2020
@tbouffard
Copy link
Member

@aibcmars as suggested in #791 (review), can we add a test to ensure that performing zoom in then zoom out (or the opposite) restore the initial scale?

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -93,4 +93,19 @@ describe('diagram navigation', () => {
const image = await page.screenshot({ fullPage: true });
expect(image).toMatchImageSnapshot(imageSnapshotConfigurator.getConfig(fileName));
});

it.each([3, 5])(`ctrl + mouse: initial scale after zoom in and zoom out [%s times]`, async (xTimes: number) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@aibcmars aibcmars merged commit 133ac4e into master Oct 28, 2020
@aibcmars aibcmars deleted the zoom-fix_proportions branch October 28, 2020 09:37
@tbouffard tbouffard added the BPMN diagram usability Something about the way we can interact with BPMN diagrams label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants