-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] fix proportions for zoom in and zoom out coherence #832
Conversation
@aibcmars as suggested in #791 (review), can we add a test |
… and zoom out same amount of times
… and zoom out same amount of times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -93,4 +93,19 @@ describe('diagram navigation', () => { | |||
const image = await page.screenshot({ fullPage: true }); | |||
expect(image).toMatchImageSnapshot(imageSnapshotConfigurator.getConfig(fileName)); | |||
}); | |||
|
|||
it.each([3, 5])(`ctrl + mouse: initial scale after zoom in and zoom out [%s times]`, async (xTimes: number) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Ensure that doing zoom in then zoom out (or the opposite) restore the initial zoom factor.