Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] improve zoom for better user experience #791

Closed
wants to merge 13 commits into from
Closed

[FEAT] improve zoom for better user experience #791

wants to merge 13 commits into from

Conversation

aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Oct 20, 2020 •
edited by tbouffard
Loading

  • throttle for cumulativeZoom calculation
  • debounce for scaleAndTranslate to limit excessive browser painting

closes #737

@aibcmars aibcmars added the WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft label Oct 20, 2020
@aibcmars aibcmars added BPMN diagram usability Something about the way we can interact with BPMN diagrams enhancement New feature or request labels Oct 22, 2020
tbouffard
tbouffard reviewed Oct 22, 2020
View reviewed changes
package.json Show resolved Hide resolved
src/component/BpmnVisualization.ts Outdated Show resolved Hide resolved
@aibcmars aibcmars force-pushed the 737-improve_zoom branch 2 times, most recently from fb9c87c to af307cd Compare October 23, 2020 12:59
@tbouffard tbouffard mentioned this pull request Oct 26, 2020
Merged
aibcmars added 13 commits October 28, 2020 11:42
@aibcmars
[FEAT] improve zoom for better user experience
e5945d4 
- throttle for cumulativeZoom calculation
- debounce for scaleAndTranslate to limit excessive browser painting
@aibcmars
[FEAT] improve zoom for better user experience
28d5018 
- configurable zoom experience
- example playground
@aibcmars
[FEAT] improve zoom for better user experience
d1ca245 
- parametr to show controls
- added labels
@aibcmars
tests snapshot updated
ab3784a
@aibcmars
clarify param usage
bded1d5
@aibcmars
clarify param usage
8cbb3ab
@aibcmars
extract zoomMax and zoomMin from this PR
814fda6
@aibcmars
extract zoomMax and zoomMin from this PR
185acd9
@aibcmars
[FEAT] improve zoom for better user experience
d190f8d 
- configurable zoom experience
- example playground
@aibcmars
extract BpmnMxgraph to facilitate merge
7de91c1
@aibcmars
merge - corrections
6aefb34
@aibcmars
tests snapshots updated
9dd6eec
@aibcmars
typo fix
70c95e6
@tbouffard tbouffard mentioned this pull request Nov 3, 2020
Open
@aibcmars
Copy link
Contributor Author

aibcmars commented Nov 5, 2020

closing, new PR will be opened (this one just for history)

@aibcmars aibcmars closed this Nov 5, 2020
@tbouffard tbouffard deleted the 737-improve_zoom branch November 6, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard left review comments

Assignees
No one assigned
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams enhancement New feature or request WIP 🚧 Pull request in progress and/or not ready for review. Used in addition to marking it as draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Improve zoom in / zoom out performance
2 participants
@aibcmars @tbouffard