Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(JsonBuilder): enforce the type of BuildEventDefinitionParameter eventDefinitionKind property in JsonBuilder #2897

Merged
merged 4 commits into from
Sep 29, 2023
Merged

test(JsonBuilder): enforce the type of BuildEventDefinitionParameter eventDefinitionKind property in JsonBuilder #2897

merged 4 commits into from
Sep 29, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Sep 28, 2023 •
edited
Loading

No description provided.

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Sep 28, 2023
@csouchet csouchet mentioned this pull request Sep 28, 2023
Merged
@csouchet csouchet changed the title chore(unit test): enforce eventDefinitionKind type in JsonBuilder test(JsonBuilder): enforce eventDefinitionKind type in JsonBuilder Sep 28, 2023
@csouchet csouchet force-pushed the test/enforce_EventDefinitionKind_type_in_JsonBuilder branch from 44bfbe8 to c64ca00 Compare September 28, 2023 15:01
@csouchet csouchet force-pushed the test/enforce_EventDefinitionKind_type_in_JsonBuilder branch from c64ca00 to ead36c1 Compare September 28, 2023 15:58
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 28, 2023
@csouchet csouchet marked this pull request as ready for review September 28, 2023 16:04
@csouchet csouchet requested a review from tbouffard September 29, 2023 08:27
tbouffard
tbouffard approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with the implementation.
The title of this PR should be clarify because I didn't understand its purpose prior reading the code. Adding a description would also help.

test/unit/helpers/JsonBuilder.ts Outdated Show resolved Hide resolved
@csouchet csouchet changed the title test(JsonBuilder): enforce eventDefinitionKind type in JsonBuilder test(JsonBuilder): enforce the type of BuildEventDefinitionParameter eventDefinitionKind property in JsonBuilder Sep 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet merged commit 68ff296 into master Sep 29, 2023
@csouchet csouchet deleted the test/enforce_EventDefinitionKind_type_in_JsonBuilder branch September 29, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard