Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(JsonBuilder): not possible to have NONE eventDefinitionOn and eventDefinitionKind in same time in BuildEventParameter #2899

Merged
merged 2 commits into from
Sep 29, 2023
Merged

test(JsonBuilder): not possible to have NONE eventDefinitionOn and eventDefinitionKind in same time in BuildEventParameter #2899

merged 2 commits into from
Sep 29, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Sep 28, 2023 •
edited
Loading

To avoid confusion, if the property eventDefinitionOn is set to NONE and the property eventDefinitionKind is set in the same instance of BuildEventParameter, an error is thrown.

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Sep 28, 2023
@csouchet csouchet changed the title chore(JsonBuilder): not possible to have none event definition on and event definition kind in same time test(JsonBuilder): not possible to have none event definition on and event definition kind in same time Sep 28, 2023
@csouchet csouchet force-pushed the test/not_possible_to_have_None_eventDefinitionOn_and_eventDefinitionKind_in_same_time branch from 53aa629 to 4c9b3e2 Compare September 28, 2023 15:03
@csouchet csouchet force-pushed the test/not_possible_to_have_None_eventDefinitionOn_and_eventDefinitionKind_in_same_time branch from 4c9b3e2 to 79a21b3 Compare September 29, 2023 12:08
@csouchet csouchet changed the title test(JsonBuilder): not possible to have none event definition on and event definition kind in same time test(JsonBuilder): not possible to have none event definition on and event definition kind in same time in BuildEventParameter Sep 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 29, 2023
@csouchet csouchet changed the title test(JsonBuilder): not possible to have none event definition on and event definition kind in same time in BuildEventParameter test(JsonBuilder): not possible to have NONE eventDefinitionOn and eventDefinitionKind in same time in BuildEventParameter Sep 29, 2023
@csouchet csouchet marked this pull request as ready for review September 29, 2023 12:14
@csouchet csouchet requested a review from tbouffard September 29, 2023 12:14
tbouffard
tbouffard approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a shorter PR title. This one is hard to read and it will overflow in the GitHub web UI.

@csouchet csouchet merged commit cdac517 into master Sep 29, 2023
@csouchet csouchet deleted the test/not_possible_to_have_None_eventDefinitionOn_and_eventDefinitionKind_in_same_time branch September 29, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard