chore(eslint): add eslint-plugin-import dependency
#2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…import/no-unresolved The package.json of 'rollup-plugin-node-externals' is malformed, so the import doesn't work with 'eslint-plugin-import'.
csouchet
added
dependencies
23 tasks
|
♻️ PR Preview d066927 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
🎊 PR Preview d066927 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2842.surge.sh 🕐 Build time: 0.02s
🤖 By surge-preview |
tbouffard
requested changes
Sep 4, 2023
| @@ -26,7 +26,6 @@ export type { Navigation } from './component/navigation'; | |||
| export * from './model/bpmn/internal'; | |||
|
|
|||
| // not part of the public API but needed for the custom theme examples | |||
| export { IconPainter } from './component/mxgraph/shape/render/icon-painter'; | |||
Unable to resolve path to module 'bpmn-visualization' import/no-unresolved
tbouffard
approved these changes
Sep 6, 2023
|
Kudos, SonarCloud Quality Gate passed! |
tbouffard
removed
the
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses linting and import-related issues. Major changes include:
import/unresolvederrors.Covers #2742
Closes #2078