Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Ensure consistent imports order in code and tests #2078

Closed
tbouffard opened this issue Jun 27, 2022 · 1 comment · Fixed by #2842
Closed

[INFRA] Ensure consistent imports order in code and tests #2078

tbouffard opened this issue Jun 27, 2022 · 1 comment · Fixed by #2842
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Milestone

Comments

@tbouffard
Copy link
Member

tbouffard commented Jun 27, 2022

To be handled as part of #2742

During the review of #2070 (review), we realized that the imports are not consistent.
Sometimes, we put a blank line between the first import and the license header, sometimes not.
In test, we generally group the imports but not all the time. And sometimes, we put the production code first, sometimes the test code.
The same occurs for imports of 3rd parties lib or Nodejs.

We first should define which rules we want to follow

  • breaking line or not between the first import and the license header
  • import order: test, code, 3rd parties, ...

We should be able to configure the rules with eslint

@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Jun 27, 2022
@tbouffard tbouffard added this to the Development Impediments milestone Jun 27, 2022
@csouchet csouchet modified the milestones: 0.38.0, 0.38.1 Jul 24, 2023
@csouchet csouchet modified the milestones: 0.38.1, 0.38.2 Aug 22, 2023
@csouchet csouchet modified the milestones: 0.38.2, 0.39.1 Sep 4, 2023
@tbouffard
Copy link
Member Author

Fixed by #2842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
Development

Successfully merging a pull request may close this issue.

2 participants