Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Don't use a select text cursor on label hover #1345

Merged
merged 3 commits into from
Jun 3, 2021
Merged

[FIX] Don't use a select text cursor on label hover #1345

merged 3 commits into from
Jun 3, 2021

Conversation

tbouffard
Copy link
Member

The text is not selectable, so use the default cursor. This prevents to let
users think that the label is editable.

Fix #294

@tbouffard
[FIX] Don't use a select text cursor on label hover
87023a6 
The text is not selectable, so use the default cursor. This prevents to let
users think that the label is editable.
@tbouffard tbouffard added bug Something isn't working BPMN rendering Something about the way the lib is rendering BPMN elements labels Jun 1, 2021
@github-actions
Copy link

github-actions bot commented Jun 1, 2021 •
edited
Loading

♻️ PR Preview 11d322a has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Jun 1, 2021 •
edited
Loading

♻️ PR Preview 11d322a has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@tbouffard tbouffard marked this pull request as draft June 2, 2021 06:58
@csouchet
Copy link
Member

csouchet commented Jun 2, 2021

Maybe you can use this property of the style: https://jgraph.github.io/mxgraph/docs/js-api/files/util/mxConstants-js.html#mxConstants.CURSOR_LABEL_HANDLE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@tbouffard
Copy link
Member Author

Maybe you can use this property of the style: jgraph.github.io/mxgraph/docs/js-api/files/util/mxConstants-js.html#mxConstants.CURSOR_LABEL_HANDLE

Handles are use to provide displayed anchor allowing to perform actions on the mxgraph cells (for instance, rotate or resize). So they are not related to the container.
In addition, the suggested constant is already set to 'default'.

https://jgraph.github.io/mxgraph/javascript/examples/handles.html

mxgraph_handles_examples

@tbouffard tbouffard marked this pull request as ready for review June 3, 2021 04:05
@csouchet csouchet merged commit e3959a1 into master Jun 3, 2021
@csouchet csouchet deleted the 294-keep_default_cursor_on_text_label_hover branch June 3, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

Assignees
No one assigned
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] mouse pointer/icon change on label hover
2 participants
@tbouffard @csouchet