[BUG] mouse pointer/icon change on label hover

[tbouffard]

Describe the bug
The mouse pointer changes when hovering on label (shape or edge): it displays a text edition pointer whereas labels are not editable.

To Reproduce
See screenshots. Can be reproduced at least with versions 0.1.1 to 0.1.5 (master branch 171cbcf)

Expected behavior
The mouse icon shouldn't show a text edition icon as labels are not editable, nor selectable.
This gives wrong direction to user letting him/her think the label is editable.

Screenshots
Portion of the B.2.0.bpmn file from BPMN-MIWG rendered with version 0.1.4

.

Desktop

• OS: Ubuntu 18.04
• Browser: Firefox 77.0.1 / Chrome 83.0.4103.97 (Official Build 64 bits)

Additional context
This may be the default mxGraph behaviour, some configuration is already setup to avoid label edition. Tests on vanilla mxGraph may be conducted to check if configuration can solve the issue.

[tbouffard]

May be fixed by a mxgraph upgrade.
See process-analytics/mxgraph2@1364dcd (not released at the time of writing, latest is 4.2.0 and doesn't contain this change)

[tbouffard]

The issue still exists with mxgraph 4.2.2
See the https://github.com/process-analytics/pa-technical-challenge/tree/0d28347323e1b2cbc797cf3917ef0af9cdc9c3df

[tbouffard]

https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/0.16.0/examples/diagram-navigation/diagram-navigation/index.html

The text cursor is replaced by a pointer cursor after a pan

After zoom, we still see the text cursor

[tbouffard]

Explanations about the cursor we see after panning

Original code

<div id="bpmn-container" class="bpmn-container">

Before pan

<div id="bpmn-container" class="bpmn-container" style="position: relative; touch-action: none;">

The style elements are set by mxGraph at initialization.

After pan

<div id="bpmn-container" class="bpmn-container"
	 style="position: relative; touch-action: none; cursor: default;">

After panning, the default cursor is set by bpmn-visualization, see #815.

[tbouffard]

Possible fix

In the bpmn container html element, we could set the cursor to default at the initialization (as we do after panning).
mxGraph examples don't suffer from the issue. Most of them set the cursor to default in the style property of the container holding the graph directly in the html source code.

Other resources
shape setting the cursor. We may decide to find a way to force the default cursor on text generated by mxgraph

• https://github.com/jgraph/mxgraph/blob/v4.2.2/javascript/src/js/shape/mxShape.js#L385
• https://github.com/jgraph/mxgraph/blob/v4.2.2/javascript/src/js/shape/mxShape.js#L422