Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Simplify the config of parcel and webpack projects #384

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Sep 15, 2022

Previously, the browser field in the package.json of bpmn-visualization was incorrect.
Without specific configuration, the following errors occured

  • parcel: Uncaught TypeError: _bpmnVisualization.BpmnVisualization is not a constructor
  • webpack: Uncaught TypeError: bpmn_visualization__WEBPACK_IMPORTED_MODULE_0__.BpmnVisualization is not a constructor

So we configured an alias for Parcel and a resolve mainFields for Webpack to ensure these bundlers use the ESM bundle file.
The browser field is now fixed, so we can remove the extra configuration.

refs process-analytics/bpmn-visualization-js#2228
refs process-analytics/bpmn-visualization-js#2248
closes #351

# Conflicts:
#	projects/typescript-vanilla-with-parcel/package.json
@tbouffard tbouffard marked this pull request as ready for review September 19, 2022 09:42
@tbouffard tbouffard merged commit 24a89d6 into master Sep 19, 2022
@tbouffard tbouffard deleted the feat/simplify_parcel_and_webpack_config branch September 19, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INFRA] The Parcel TS project is not udpated correctly by the script updating the bpmn-visualization version
1 participant