Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] The Parcel TS project is not udpated correctly by the script updating the bpmn-visualization version #351

Closed
csouchet opened this issue Jun 13, 2022 · 2 comments · Fixed by #384
Closed

[INFRA] The Parcel TS project is not udpated correctly by the script updating the bpmn-visualization version #351

csouchet opened this issue Jun 13, 2022 · 2 comments · Fixed by #384
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Comments

@csouchet
Copy link
Member

csouchet commented Jun 13, 2022 •
edited by tbouffard
Loading

When I released the 0.24.1 version of the bpmn-visualization library, the projects/typescript-vanilla-with-parcel/package.json file has an unwanted update:

"alias": {
  "bpmn-visualization": "bpmn-visualization/dist/bpmn-visualization.esm.js"
}

replaced by

"alias": {
  "bpmn-visualization": "0.24.1"
}

See #350 for more details

To fix that, we may update the regexp in the script scripts/update-lib-version.bash.
@csouchet csouchet added the bug Something isn't working label Jun 13, 2022
@tbouffard
Copy link
Member

We could try to replace the alias configuration in the package.json by a settings in a Parcel configuration file, as we do for Webpack.
See #338 (comment)

@tbouffard tbouffard changed the title [BUG] The script to update the BPMN Visualization TS version must not change the alias in the package.json file [BUG] The Parcel TS project is not udpated correctly by the script updating the bpmn-visualization version Jun 13, 2022
@tbouffard tbouffard added infra:repo and removed bug Something isn't working labels Jun 27, 2022
@tbouffard tbouffard changed the title [BUG] The Parcel TS project is not udpated correctly by the script updating the bpmn-visualization version [INFRA] The Parcel TS project is not udpated correctly by the script updating the bpmn-visualization version Jun 27, 2022
@tbouffard tbouffard mentioned this issue Jun 27, 2022
Merged
@tbouffard tbouffard added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) and removed infra:repo labels Aug 29, 2022
@tbouffard tbouffard mentioned this issue Sep 11, 2022
Closed
@tbouffard tbouffard mentioned this issue Sep 19, 2022
Merged
@tbouffard
Copy link
Member

The alias is going to be removed in #384. It was needed as the "browser" field in the bpmn-visualization package.json was wrong.
This field has been fixed in v0.26.2 so the alias can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
2 participants
@csouchet @tbouffard