Add log backend in order to deprecate the rtt-log crate #56
+157
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
approved these changes
Nov 30, 2024
There was a problem hiding this comment.
I don't think I can approve this PR, but it looks good to me. I guess I can.
Though I think we should make it clear that these implementations don't prevent third party backends that may be more suitable for particular systems - e.g. backends that don't use global critical sections to better suit multi-core MCUs.
|
Ok. I've added a note, regarding possible other options: + **Note**: For your platform, particularly if you're using a multi-core MCU, external logger implementations might be better suited than the one provided by this crate via the `log`/`defmt` feature.@probe-rs/core @sourcebox |
I think this can be merged and released. I will then add a note to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See probe-rs/embedded-test#47