Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rtt-log crate #47

Closed
t-moe opened this issue Nov 15, 2024 · 2 comments
Closed

Replace rtt-log crate #47

t-moe opened this issue Nov 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@t-moe
Copy link
Contributor

t-moe commented Nov 15, 2024

Sourcebox via Matrix:

I've seen embedded-test uses my rtt-log crate. While I appreciate this, I'm not sure if it's really a good idea in the long-term because of possible version conflicts with rtt-target. Because my crate as well as embedded-test has it as dependency, the version must match. The functionality of rtt-log is very little and there was some discussion long ago to directly include logging into rtt-target. Someone just has to do it.

Also: rtt-log does not allow to logging in blocking rtt mode (only discard on overflow)

@t-moe t-moe added the enhancement New feature or request label Nov 15, 2024
@sourcebox
Copy link

If it's desired to have logging in a separate crate, I could also transfer ownership of rtt-log to the probe-rs organisation. That way, it would be easier to keep the versions in sync and add new features.

@t-moe
Copy link
Contributor Author

t-moe commented Dec 3, 2024

Ok, so rtt-target 0.6.1 has been released.

Furthermore, the next embedded-test version will no longer depend on rtt-target or rtt-log, instead the users are encouraged to use something like #[embedded_test::tests(setup=rtt_target::rtt_init_log!())] if they want to setup logging early.

@t-moe t-moe closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants