-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: displaying social icons with valid social URL #1989
Conversation
Signed-off-by: Tushar Saini <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @s2sharpit! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
@s2sharpit we need to change the
|
Sure @priyankarpal |
Signed-off-by: Tushar Saini <[email protected]>
Signed-off-by: Tushar Saini <[email protected]>
… into social-icons
Done @priyankarpal |
Signed-off-by: Tushar Saini <[email protected]>
Signed-off-by: Tushar Saini <[email protected]>
Signed-off-by: Tushar Saini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 🎉
@s2sharpit the changes have been made, so we need to update the documentation as well. You can create a separate issue for the documentation. |
Yaa Sure |
Related Issue
Closes: #1982
Description
displaying social icons with valid social URL
Changes
Screenshots