Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: displaying social icons with valid social URL #1989

Merged
merged 9 commits into from
Aug 7, 2023

Conversation

s2sharpit
Copy link
Contributor

Related Issue

Closes: #1982

Description

displaying social icons with valid social URL

Changes

  • implemented logic to show the icons only when the string is not empty
  • for GitHub, adding URL based on the collected GitHub username as some users are not adding GitHub account URL.

Screenshots

Original Updated
image image

@vercel
Copy link

vercel bot commented Aug 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
projectshut ✅ Ready (Inspect) Visit Preview Aug 7, 2023 7:38am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @s2sharpit! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@priyankarpal
Copy link
Owner

@s2sharpit we need to change the json format

  • delete extra social accounts code
  • also, for github delete "gitHub": "https://github.com/Sahilll15",

@priyankarpal priyankarpal added the changes-required changes-required label Aug 6, 2023
@s2sharpit
Copy link
Contributor Author

@s2sharpit we need to change the json format

  • delete extra social accounts code
  • also, for github delete "gitHub": "https://github.com/Sahilll15",

Sure @priyankarpal

@s2sharpit
Copy link
Contributor Author

@s2sharpit we need to change the json format

  • delete extra social accounts code
  • also, for github delete "gitHub": "https://github.com/Sahilll15",

Sure @priyankarpal

Done @priyankarpal

Signed-off-by: Tushar Saini <[email protected]>
DB/projects.json Outdated Show resolved Hide resolved
@priyankarpal priyankarpal added the ❓ talk: question Further information is requested label Aug 7, 2023
Copy link
Owner

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🎉

@priyankarpal priyankarpal removed ❓ talk: question Further information is requested projects addition add your projects labels Aug 7, 2023
@priyankarpal priyankarpal added gssoc23 only for Girlscript summer of code level3 high level fix for GSSoC and removed changes-required changes-required labels Aug 7, 2023
@priyankarpal
Copy link
Owner

@s2sharpit the changes have been made, so we need to update the documentation as well. You can create a separate issue for the documentation.

@priyankarpal priyankarpal merged commit 43c2224 into priyankarpal:main Aug 7, 2023
10 checks passed
@s2sharpit
Copy link
Contributor Author

@s2sharpit the changes have been made, so we need to update the documentation as well. You can create a separate issue for the documentation.

Yaa Sure

@s2sharpit s2sharpit deleted the social-icons branch August 7, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 only for Girlscript summer of code level3 high level fix for GSSoC wait for reviewers wait for the maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Display Social Icons Only with Valid Social URLs
2 participants