-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Display Social Icons Only with Valid Social URLs #1982
Comments
To reduce notifications, issues are locked. Your issue will be unlock when we will add label as |
yeah we need to do this. Also, I was thinking we should collect only 3 social accounts (GitHub, LinkedIn, Twitter) for now
after we can use GitHub API to fetch all details (repo tech stacks, names, social accounts(if exists)) What do you think? @s2sharpit |
Hey @priyankarpal, Sounds like a good plan! I agree with collecting only 3 social accounts now (GitHub, LinkedIn, Twitter). However, we'll still need to collect the LinkedIn account since we won't be able to fetch it through an API. Regarding fetching the tech stack, we have two approaches. The first one is to fetch languages using the GitHub API, but it has a limitation. It will only show individual languages like JavaScript or TypeScript, not the complete tech stack. For instance, if someone has a React project, it will only display the language used, not the entire tech stack. The second approach is to fetch topics from the GitHub API. However, this approach relies on users adding the tech stack information themselves to their repositories. I think this approach will be better. Let's carefully consider these options and decide on the best way to handle the tech stack section. Your thoughts on this, @priyankarpal? Example for Tech Stack Section:This below data is of this repo: https://github.com/s2sharpit/s2sharpit
|
so @s2sharpit we need to collect social accounts (github, linkedin & twitter) manually. |
For github account, as you said, we are collecting the username, therefore I think we can manage it. But for twitter & linkedin. We have to collect it. |
for now we should skip GitHub API part. & we need to work on Social accounts issue. For Documentation you can create separate issue |
Sure @priyankarpal, BTW can you check this issue: #1983 |
yeah sure after solving this issue you can work |
What happened?
Issue Description:
Currently, our website displays all social icons on the page, regardless of whether they have valid social URLs associated with them or not. Clicking on any of these icons leads to the same page in a new tab, which can be confusing for users and leads to a suboptimal user experience.
Proposed Improvement:
We should modify the social icon display behavior so that only those icons with valid social URLs are shown to the users. This way, visitors can easily find and access our official social media profiles without any confusion. Icons without valid URLs should be hidden or disabled to avoid misleading clicks.
Expected Behavior:
Benefits:
Add screenshots
20230806_200027.mp4
What browsers are you seeing the problem on?
No response
Record
The text was updated successfully, but these errors were encountered: