fix: make it possible to build the engines without .git directory
#4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #4986. * Change the `build.rs` scripts to pass through the `GIT_HASH` environment variable if it's already set. * Set dummmy `GIT_HASH` value in the Nix packages used in the engines size dashboard. * Consistently use the new logic everywhere. Fixes: #4991 Closes: prisma/team-orm#1261
aqrln
commented
Aug 27, 2024
| @@ -1,13 +1,4 @@ | |||
| extern crate cbindgen; | |||
There was a problem hiding this comment.
extern crate removal is unrelated, opportunistic cleanup
CodSpeed Performance ReportMerging #4992 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
13 tasks
jkomyno
approved these changes
Aug 28, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4986.
build.rsscripts to pass through theGIT_HASHenvironment variable if it's already set.GIT_HASHvalue in the Nix packages used in the engines size dashboard.Fixes: #4991
Closes: https://github.com/prisma/team-orm/issues/1261