{prisma,prisma-engines}: 5.16.1 -> 5.18.0 #337521
Conversation
|
Hey, 5.19 is now released but prisma/prisma-engines#4992 didn't make it into the release which will be a small problem that will require patching here (or using that commit) after all. |
|
I included a quick attempt at packaging prisma 5.18.0. It prints out the expected output in Looking for initial feedback. |
|
I tested
|
szlend
force-pushed
the
prisma-engines-5.18
branch
2 times, most recently
from
c1e56de
to
645cfc0
Compare
github-actions
bot
added
6.topic: nixos
|
@aqrln unless you object, I think I would just start with |
szlend
changed the title
szlend
force-pushed
the
prisma-engines-5.18
branch
from
645cfc0
to
0d33ab5
Compare
| }; | ||
| prisma = nodeEnv.buildNodePackage { | ||
| name = "prisma"; | ||
| packageName = "prisma"; | ||
| version = "5.17.0"; | ||
| src = fetchurl { | ||
| url = "https://registry.npmjs.org/prisma/-/prisma-5.17.0.tgz"; | ||
| sha512 = "m4UWkN5lBE6yevqeOxEvmepnL5cNPEjzMw2IqDB59AcEV6w7D8vGljDLd1gPFH+W6gUxw9x7/RmN5dCS/WTPxA=="; | ||
| }; | ||
| dependencies = [ | ||
| sources."@prisma/debug-5.17.0" | ||
| sources."@prisma/engines-5.17.0" | ||
| sources."@prisma/engines-version-5.17.0-31.393aa359c9ad4a4bb28630fb5613f9c281cde053" | ||
| sources."@prisma/fetch-engine-5.17.0" | ||
| sources."@prisma/get-platform-5.17.0" | ||
| ]; | ||
| buildInputs = globalBuildInputs; | ||
| meta = { | ||
| description = "Prisma is an open-source database toolkit. It includes a JavaScript/TypeScript ORM for Node.js, migrations and a modern GUI to view and edit the data in your database. You can use Prisma in new projects or add it to an existing one."; | ||
| homepage = "https://www.prisma.io"; | ||
| license = "Apache-2.0"; | ||
| }; | ||
| production = true; | ||
| bypassCache = true; | ||
| reconstructLock = true; | ||
| }; | ||
| "@prisma/language-server" = nodeEnv.buildNodePackage { | ||
| name = "_at_prisma_slash_language-server"; | ||
| packageName = "@prisma/language-server"; | ||
| version = "5.17.0"; | ||
| src = fetchurl { | ||
| url = "https://registry.npmjs.org/@prisma/language-server/-/language-server-5.17.0.tgz"; | ||
| sha512 = "4XXTBGpwJBUFqvY2WxL/4W1q/OOstxCJER4TYftNgMGjKjnsFkQNme567QTlPwWp7VGw2jcNmyTFOcP4HdohIg=="; | ||
| }; | ||
| dependencies = [ | ||
| sources."@prisma/prisma-schema-wasm-5.17.0-31.393aa359c9ad4a4bb28630fb5613f9c281cde053" | ||
| sources."@prisma/schema-files-loader-5.17.0" | ||
| sources."@types/js-levenshtein-1.1.3" | ||
| sources."fs-extra-11.1.1" | ||
| sources."graceful-fs-4.2.11" | ||
| sources."js-levenshtein-1.1.6" | ||
| sources."jsonfile-6.1.0" | ||
| sources."klona-2.0.6" | ||
| sources."universalify-2.0.1" | ||
| sources."vscode-jsonrpc-8.1.0" | ||
| sources."vscode-languageserver-8.1.0" | ||
| sources."vscode-languageserver-protocol-3.17.3" | ||
| sources."vscode-languageserver-textdocument-1.0.11" | ||
| sources."vscode-languageserver-types-3.17.3" | ||
| sources."vscode-uri-3.0.8" | ||
| ]; | ||
| buildInputs = globalBuildInputs; | ||
| meta = { | ||
| description = "Prisma Language Server"; | ||
| homepage = "https://github.com/prisma/language-tools#readme"; | ||
| license = "Apache-2.0"; | ||
| }; | ||
| production = true; | ||
| bypassCache = true; | ||
| reconstructLock = true; | ||
| }; |
There was a problem hiding this comment.
I don't know how to re-generate this file without touching unrelated packages. I manually deleted all the prisma references, but I'm sure there are probably some zombie dependencies left as a result. Let me know if there's a better way to do this.
Is this fixed now that you are patching the |
It's fine with me either way. I don't see much value in keeping 5.18.0 since the next version is not a major release but I won't object if you prefer this. |
|
Tomorrow I should have enough time to address the comments and finish this. Though if this is blocking anyone, feel free to pick it up. |
szlend
force-pushed
the
prisma-engines-5.18
branch
3 times, most recently
from
462e6aa
to
4d50dba
Compare
|
I resolved all the issues. Installing workspace packages is really janky without I'm keeping the package at |
szlend
force-pushed
the
prisma-engines-5.18
branch
from
4d50dba
to
dcbcaee
Compare
due to NixOS/nixpkgs#337521 Signed-off-by: Florian Brandes <[email protected]>
|
I'm not familiar with the |
My understanding of package renames is that there should always be an alias/deprecation period, such that users upgrading from (e.g.) 24.05->24.11 would have chance to migrate without their config immediately breaking. |
Due to NixOS/nixpkgs#337521 Signed-off-by: Florian Brandes <[email protected]>
|
Fixed in #338679 |
Due to NixOS/nixpkgs#337521 Signed-off-by: Florian Brandes <[email protected]>
Due to NixOS/nixpkgs#337521 Signed-off-by: Florian Brandes <[email protected]>
Due to NixOS/nixpkgs#337521 Signed-off-by: Florian Brandes <[email protected]>
Due to NixOS/nixpkgs#337521 Signed-off-by: Florian Brandes <[email protected]>
Due to NixOS/nixpkgs#337521 Signed-off-by: Florian Brandes <[email protected]>
Due to NixOS/nixpkgs#337521 Signed-off-by: Florian Brandes <[email protected]>
Due to NixOS/nixpkgs#337521 Signed-off-by: Florian Brandes <[email protected]>
Description of changes
Updates
prisma-enginesto v5.18.0Diff: prisma/prisma-engines@5.16.1...5.18.0
Includes a patched
Cargo.lockwith thetimecrate updated to0.3.36which fixes builds under Rust v1.80. Updated with the commandcargo update -p time.See prisma/prisma-engines#4989
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.