Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning scheme #121

Closed
divyenduz opened this issue Apr 28, 2020 · 3 comments · Fixed by #126
Closed

Versioning scheme #121

divyenduz opened this issue Apr 28, 2020 · 3 comments · Fixed by #126
Assignees
Labels
kind/improvement An improvement to existing feature and code.
Milestone

Comments

@divyenduz
Copy link

divyenduz commented Apr 28, 2020

Since #93 is not possible at the moment, we need to find a versioning schema that works for us.

Currently, we have "patch" versioning #114 in place but that means that extension version increments independent of Prisma version. That makes it difficult for us to know which extension version uses which Prisma version internally.

An alternative can be to use an extension version that can be derived from Prisma version but that supports marketplace versioning scheme:

It must be one to four numbers in the range 0 to 2147483647, with each number seperated by a period. It must contain at least one non-zero number. (related issue microsoft/vscode-vsce#148)

Consideration: Support extension only release

@divyenduz
Copy link
Author

divyenduz commented Apr 28, 2020

Suggestion from Jan, for pre-release versions, drop the 2 since we plan to keep it for a long time and then remove the pre release identified (-dev, -beta, -alpha). Keep the remainder of the version and add a .x for extension only publishing.

With the current versioning scheme

Stable Channel

Prisma Version Extension Version Extension Only Release
2.0.0-beta.3 0.0.3 0.0.3.1

Unstable Channel

Prisma Version Extension Version Extension Only Release
2.0.0-alpha.1149 0.0.1149 0.0.1149.1

With the upcoming versioning scheme

Stable Channel

Prisma Version Extension Version Extension Only Release
2.0.1 2.0.1 2.0.1.1

Unstable Channel

Prisma Version Extension Version Extension Only Release
2.0.1-dev.1 0.1.1 0.1.1.1
2.0.1-dev.12 0.1.12 0.1.12.1

@divyenduz
Copy link
Author

divyenduz commented May 4, 2020

#126 implements this. The only case where this doesn't work is for the stable extension version today

Version Value Comments
Prisma version 2.0.0-beta.4
Current extension version 0.0.35
Proposed extension version 0.0.4 The proposed version is smaller then 0.0.35

Update: Since we are moving to 2.0.x.y versioning schema after GA. We can use 0.1.x.y now instead of 0.0.x.y for beta pre-release tag.

@divyenduz
Copy link
Author

Related issue for extension only release workflow #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants