Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test cases that point to a four digit versioning scheme #247

Closed
divyenduz opened this issue Jun 17, 2020 · 0 comments · Fixed by #300
Closed

Remove test cases that point to a four digit versioning scheme #247

divyenduz opened this issue Jun 17, 2020 · 0 comments · Fixed by #300
Assignees
Labels
kind/improvement An improvement to existing feature and code.
Milestone

Comments

@divyenduz
Copy link

divyenduz commented Jun 17, 2020

We recently found out that the four-digit versioning we agreed to (#121 (comment)) is not possible as vsce/npm don't work with it.

This PR tracks the removal of the outdated code/test cases that are based on the 4 digit extension assumption as these test cases/references may be misleading.

We need a new versioning schema for Prisma CLI patches and extension only publishing.

That is being tracked in these issues:

#240
#143

P.S. and also remove pre GA test cases for extension version as they are no longer needed.

@divyenduz divyenduz added process/candidate Candidate for next Milestone. kind/improvement An improvement to existing feature and code. labels Jun 17, 2020
@janpio janpio added this to the 2.2.0 milestone Jun 24, 2020
@janpio janpio removed the process/candidate Candidate for next Milestone. label Jun 25, 2020
@carmenberndt carmenberndt self-assigned this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants