Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old TextInput src files #2991

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Remove old TextInput src files #2991

merged 2 commits into from
Mar 6, 2023

Conversation

langermank
Copy link
Contributor

I moved these to their own folder, but forgot to delete the old src

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@langermank langermank requested review from a team and colebemis March 6, 2023 20:19
@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9c9a81e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@langermank langermank temporarily deployed to github-pages March 6, 2023 20:26 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2991 March 6, 2023 20:26 Inactive
joshblack
joshblack requested changes Mar 6, 2023
View reviewed changes
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Seems like there are some missing exports but should be good to go after that

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 94.65 KB (0%)
dist/browser.umd.js 95.22 KB (0%)

@langermank langermank added the skip changeset This change does not need a changelog label Mar 6, 2023
@langermank langermank enabled auto-merge March 6, 2023 21:21
@langermank langermank added this pull request to the merge queue Mar 6, 2023
Merged via the queue into main with commit 338cbf1 Mar 6, 2023
@langermank langermank deleted the remove-old-src-input branch March 6, 2023 21:45
@ollie-iterators ollie-iterators mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@colebemis colebemis Awaiting requested review from colebemis

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @joshblack