Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated ActionMenu file #2992

Closed
ollie-iterators opened this issue Mar 6, 2023 · 6 comments · Fixed by #3713
Closed

Remove duplicated ActionMenu file #2992

ollie-iterators opened this issue Mar 6, 2023 · 6 comments · Fixed by #3713
Assignees
Labels
bug Something isn't working react

Comments

@ollie-iterators
Copy link

ollie-iterators commented Mar 6, 2023

Description

Since #2991 was merged. I was thinking about if there are some other files that need to be deleted in the src file.

I think these files need to be removed:

  • ActionMenu.tsx
  • Dialog.docs.json
  • Dialog.tsx

Updated by @broccolinisoup : Dialog changes are reverted, so only ActionMenu.tsx needs to be deleted.

Steps to reproduce

Check out the file: https://github.com/primer/react/tree/main/src

The ActionMenu and Dialog elements have been migrated to their own files but still have files in the src file.

Version

35.2.0

Browser

No response

@ollie-iterators ollie-iterators added the bug Something isn't working label Mar 6, 2023
@joshblack
Copy link
Member

Thanks @ollie-iterators for taking the time to make this issue! 🙏

This is a great point, looking into it I think Dialog is related to v1 of the component (did I get that right @broccolinisoup?)

For ActionMenu, is this similar to TextInput @langermank and we should remove it, as well?

@ollie-iterators
Copy link
Author

There may be others that were different enough that I did not put in the list like header / heading

@langermank
Copy link
Contributor

@joshblack yeah, looks like I missed ActionMenu- so that should be deleted as well. I'll open a PR.

@broccolinisoup
Copy link
Member

@joshblack Yes! They belong to the v1 and we need to keep these for now as it hasn't been migrated yet.

@lesliecdubs
Copy link
Member

👋🏻 @langermank I'm going to assign this to you since I saw you said you'd open a PR. Give us a holler if that doesn't close this issue.

@broccolinisoup
Copy link
Member

broccolinisoup commented Mar 13, 2023

Just to note that Dialog has been moved into the folder as well and no standalone file under the src for Dialog #3019

@iansan5653 iansan5653 changed the title I think there are some files that need to be removed from the src file. Remove duplicated ActionMenu file Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants