-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated ActionMenu
file
#2992
Comments
Thanks @ollie-iterators for taking the time to make this issue! 🙏 This is a great point, looking into it I think Dialog is related to v1 of the component (did I get that right @broccolinisoup?) For ActionMenu, is this similar to TextInput @langermank and we should remove it, as well? |
There may be others that were different enough that I did not put in the list like header / heading |
@joshblack yeah, looks like I missed ActionMenu- so that should be deleted as well. I'll open a PR. |
@joshblack Yes! They belong to the v1 and we need to keep these for now as it hasn't been migrated yet. |
👋🏻 @langermank I'm going to assign this to you since I saw you said you'd open a PR. Give us a holler if that doesn't close this issue. |
Just to note that |
ActionMenu
file
Description
Since #2991 was merged. I was thinking about if there are some other files that need to be deleted in the src file.
I think these files need to be removed:
Dialog.docs.jsonDialog.tsxUpdated by @broccolinisoup : Dialog changes are reverted, so only
ActionMenu.tsx
needs to be deleted.Steps to reproduce
Check out the file: https://github.com/primer/react/tree/main/src
The ActionMenu and Dialog elements have been migrated to their own files but still have files in the src file.
Version
35.2.0
Browser
No response
The text was updated successfully, but these errors were encountered: