Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jules color blind theme setup #236

Merged
merged 7 commits into from
Sep 15, 2021
Merged

Jules color blind theme setup #236

merged 7 commits into from
Sep 15, 2021

Conversation

Juliusschaeper
Copy link
Contributor

  • Added new theme files for Light / Dark Protanopia
  • Replaced Red/Green with Blue/Orange color blind optimized scales

@Juliusschaeper
Added light and dark color blind themes
be21e26 
Not sure if this makes any sense, I just copied what we did with dimmed and high contrast 🤷‍♂️
@Juliusschaeper
Updated index file with new theme files
4c216be
@Juliusschaeper
Replaced Green + Red in light and dark colorblind palettes
4b91e7f 
- Green → optimized Blue
- Red → optimized Orange
@Juliusschaeper
Changed colorblind theme names
52a27e7 
Colorblind wasn’t appropriate so I changed it to Protanopia. Protanopia stands for Red/Green blindness.
@Juliusschaeper Juliusschaeper self-assigned this Sep 15, 2021
@Juliusschaeper Juliusschaeper requested a review from a team as a code owner September 15, 2021 14:49
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: b23594c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 15, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/HAwjrkc95dt528N3tFDykmvsj3jp
✅ Preview: https://primitives-git-jules-color-blind-theme-setup-primer.vercel.app

colebemis
colebemis reviewed Sep 15, 2021
View reviewed changes
.changeset/popular-pugs-beg.md Outdated Show resolved Hide resolved
.changeset/popular-pugs-beg.md Outdated Show resolved Hide resolved
data/colors/themes/dark_protanopia Outdated Show resolved Hide resolved
colebemis
colebemis approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@jonrohan jonrohan merged commit ec5eb62 into main Sep 15, 2021
@jonrohan jonrohan deleted the jules-color-blind-theme-setup branch September 15, 2021 22:34
@primer-css primer-css mentioned this pull request Sep 15, 2021
Merged
@Juliusschaeper Juliusschaeper mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees

@Juliusschaeper Juliusschaeper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Juliusschaeper @colebemis @jonrohan