-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added light & dark colorblind themes #1596
Conversation
🦋 Changeset detectedLatest commit: 3ba0c50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -3,9 +3,12 @@ | |||
@import "../support/mixins/color-modes.scss"; | |||
|
|||
@import "@primer/primitives/dist/scss/colors/_light.scss"; | |||
@import "@primer/primitives/dist/scss/colors/_light_protanopia.scss"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this file is not available. @jonrohan Shouldn't @primer/[email protected]
get picked up automatically after changing to the ^
in #1594?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change still only uses the one specified in package.json, but it looses the restriction of a codebase that requires both primer/css
and primer/primitives
.
Basically telling npm, I use 4.7.1, but if someone is using me and needs 4.8.0 then I can use that also.
I've pushed a commit to update to 4.8.0 in this pr to fix the problem.
Just adding the new colorblind themes to
src/base/modes.scss
Related to
/cc @primer/css-reviewers