Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added light & dark colorblind themes #1596

Merged
merged 6 commits into from
Sep 16, 2021
Merged

Conversation

Juliusschaeper
Copy link
Contributor

Just adding the new colorblind themes to src/base/modes.scss

Related to

/cc @primer/css-reviewers

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2021

🦋 Changeset detected

Latest commit: 3ba0c50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -3,9 +3,12 @@
@import "../support/mixins/color-modes.scss";

@import "@primer/primitives/dist/scss/colors/_light.scss";
@import "@primer/primitives/dist/scss/colors/_light_protanopia.scss";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this file is not available. @jonrohan Shouldn't @primer/[email protected] get picked up automatically after changing to the ^ in #1594?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change still only uses the one specified in package.json, but it looses the restriction of a codebase that requires both primer/css and primer/primitives.

Basically telling npm, I use 4.7.1, but if someone is using me and needs 4.8.0 then I can use that also.

I've pushed a commit to update to 4.8.0 in this pr to fix the problem.

@jonrohan jonrohan merged commit dc99ed8 into main Sep 16, 2021
@jonrohan jonrohan deleted the jules-adding-colorblind-themes branch September 16, 2021 16:34
@primer-css primer-css mentioned this pull request Sep 16, 2021
@jonrohan jonrohan restored the jules-adding-colorblind-themes branch September 16, 2021 18:10
jonrohan added a commit that referenced this pull request Sep 16, 2021
jonrohan added a commit that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants