-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update marketing buttons (including color mode support) #1716
Conversation
🦋 Changeset detectedLatest commit: 2a84afa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far looks good. ✨
Are the !important
needed to override utilities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, did the following:
- Updated
primer/primitives
to7.0.1
that includes the newmktg
variables e372b03 - Replace the temp variables with
primer/primitives
variables e258ff5
@tobiasahlin does this 👀 preview look right? Looks good to me. 👍
Maybe one question before merging: When we ship this to dotcom, will there be lots of refactoring needed? Like replace all the updated btn classes?
@simurai amazing, thank you for pulling in those changes and replacing all the overrides! 🙏 Preview looks great 👀 I just replaced the replacement suggestion of
@simurai yes a few updates, but it'll be a fairly light lift. All of these styles are already in .com with custom overrides, so there'll be no visual changes with this update, just replacing classes and cleaning up the temporary custom overrides 🙏 |
Ok, let's 🚢 this. |
This PR upstreams the latest changes to marketing buttons from github.com, which includes proper support for color modes. Preview:
buttons-draft.mov
primer/primitives#265 is intended to land first (
primer/[email protected]
), at which point this PR can be updated to use those variables instead of local overrides./cc @primer/css-reviewers