Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for new gloss buttons with color mode support #265

Merged
merged 5 commits into from
Nov 3, 2021

Conversation

tobiasahlin
Copy link
Contributor

This PR updates color variables to replace the temporary overrides in primer/css#1716 👀

@tobiasahlin tobiasahlin requested a review from a team as a code owner November 1, 2021 12:34
@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2021

🦋 Changeset detected

Latest commit: 556db09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/bNphyyjusMUVV36BvUvbQq1fZJdf
✅ Preview: https://primitives-git-tobiasahlin-prepare-for-mktg-buttons-v2-primer.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2021

Variables changed
--- base/dist/scss/colors/_dark.scss	2021-11-01 21:04:24.768934904 +0000
+++ dist/scss/colors/_dark.scss	2021-11-01 21:04:14.520726393 +0000
@@ -148,33 +148,7 @@
     --color-project-gradient-out: rgba(22,27,34,0);
-    --color-mktg-success: rgba(41,147,61,1);
-    --color-mktg-info: rgba(42,123,243,1);
-    --color-mktg-bg-shade-gradient-top: rgba(1,4,9,0.065);
-    --color-mktg-bg-shade-gradient-bottom: rgba(1,4,9,0);
-    --color-mktg-btn-bg-top: hsla(228,82%,66%,1);
-    --color-mktg-btn-bg-bottom: #4969ed;
-    --color-mktg-btn-bg-overlay-top: hsla(228,74%,59%,1);
-    --color-mktg-btn-bg-overlay-bottom: #3355e0;
-    --color-mktg-btn-text: #f0f6fc;
-    --color-mktg-btn-primary-bg-top: hsla(137,56%,46%,1);
-    --color-mktg-btn-primary-bg-bottom: #2ea44f;
-    --color-mktg-btn-primary-bg-overlay-top: hsla(134,60%,38%,1);
-    --color-mktg-btn-primary-bg-overlay-bottom: #22863a;
-    --color-mktg-btn-primary-text: #f0f6fc;
-    --color-mktg-btn-enterprise-bg-top: hsla(249,100%,72%,1);
-    --color-mktg-btn-enterprise-bg-bottom: #6f57ff;
-    --color-mktg-btn-enterprise-bg-overlay-top: hsla(248,65%,63%,1);
-    --color-mktg-btn-enterprise-bg-overlay-bottom: #614eda;
-    --color-mktg-btn-enterprise-text: #f0f6fc;
-    --color-mktg-btn-outline-text: #f0f6fc;
-    --color-mktg-btn-outline-border: rgba(240,246,252,0.3);
-    --color-mktg-btn-outline-hover-text: #f0f6fc;
-    --color-mktg-btn-outline-hover-border: rgba(240,246,252,0.5);
-    --color-mktg-btn-outline-focus-border: #f0f6fc;
-    --color-mktg-btn-outline-focus-border-inset: rgba(240,246,252,0.5);
-    --color-mktg-btn-dark-text: #f0f6fc;
-    --color-mktg-btn-dark-border: rgba(240,246,252,0.3);
-    --color-mktg-btn-dark-hover-text: #f0f6fc;
-    --color-mktg-btn-dark-hover-border: rgba(240,246,252,0.5);
-    --color-mktg-btn-dark-focus-border: #f0f6fc;
-    --color-mktg-btn-dark-focus-border-inset: rgba(240,246,252,0.5);
+    --color-mktg-btn-bg: #f6f8fa;
+    --color-mktg-btn-shadow-outline: rgb(255 255 255 / 25%) 0 0 0 1px inset;
+    --color-mktg-btn-shadow-focus: rgb(255 255 255 / 25%) 0 0 0 4px;
+    --color-mktg-btn-shadow-hover: 0 4px 7px rgba(0, 0, 0, 0.15), 0 100px 80px rgba(255, 255, 255, 0.02), 0 42px 33px rgba(255, 255, 255, 0.024), 0 22px 18px rgba(255, 255, 255, 0.028), 0 12px 10px rgba(255, 255, 255, 0.034), 0 7px 5px rgba(255, 255, 255, 0.04), 0 3px 2px rgba(255, 255, 255, 0.07);
+    --color-mktg-btn-shadow-hover-muted: rgb(255 255 255) 0 0 0 2px inset;
     --color-avatar-bg: rgba(240,246,252,0.1);
--- base/dist/scss/colors/_dark_colorblind.scss	2021-11-01 21:04:24.784935230 +0000
+++ dist/scss/colors/_dark_colorblind.scss	2021-11-01 21:04:14.540726800 +0000
@@ -148,33 +148,7 @@
     --color-project-gradient-out: rgba(22,27,34,0);
-    --color-mktg-success: rgba(25,119,239,1);
-    --color-mktg-info: rgba(42,123,243,1);
-    --color-mktg-bg-shade-gradient-top: rgba(1,4,9,0.065);
-    --color-mktg-bg-shade-gradient-bottom: rgba(1,4,9,0);
-    --color-mktg-btn-bg-top: hsla(228,82%,66%,1);
-    --color-mktg-btn-bg-bottom: #4969ed;
-    --color-mktg-btn-bg-overlay-top: hsla(228,74%,59%,1);
-    --color-mktg-btn-bg-overlay-bottom: #3355e0;
-    --color-mktg-btn-text: #f0f6fc;
-    --color-mktg-btn-primary-bg-top: hsla(137,56%,46%,1);
-    --color-mktg-btn-primary-bg-bottom: #2ea44f;
-    --color-mktg-btn-primary-bg-overlay-top: hsla(134,60%,38%,1);
-    --color-mktg-btn-primary-bg-overlay-bottom: #22863a;
-    --color-mktg-btn-primary-text: #f0f6fc;
-    --color-mktg-btn-enterprise-bg-top: hsla(249,100%,72%,1);
-    --color-mktg-btn-enterprise-bg-bottom: #6f57ff;
-    --color-mktg-btn-enterprise-bg-overlay-top: hsla(248,65%,63%,1);
-    --color-mktg-btn-enterprise-bg-overlay-bottom: #614eda;
-    --color-mktg-btn-enterprise-text: #f0f6fc;
-    --color-mktg-btn-outline-text: #f0f6fc;
-    --color-mktg-btn-outline-border: rgba(240,246,252,0.3);
-    --color-mktg-btn-outline-hover-text: #f0f6fc;
-    --color-mktg-btn-outline-hover-border: rgba(240,246,252,0.5);
-    --color-mktg-btn-outline-focus-border: #f0f6fc;
-    --color-mktg-btn-outline-focus-border-inset: rgba(240,246,252,0.5);
-    --color-mktg-btn-dark-text: #f0f6fc;
-    --color-mktg-btn-dark-border: rgba(240,246,252,0.3);
-    --color-mktg-btn-dark-hover-text: #f0f6fc;
-    --color-mktg-btn-dark-hover-border: rgba(240,246,252,0.5);
-    --color-mktg-btn-dark-focus-border: #f0f6fc;
-    --color-mktg-btn-dark-focus-border-inset: rgba(240,246,252,0.5);
+    --color-mktg-btn-bg: #f6f8fa;
+    --color-mktg-btn-shadow-outline: rgb(255 255 255 / 25%) 0 0 0 1px inset;
+    --color-mktg-btn-shadow-focus: rgb(255 255 255 / 25%) 0 0 0 4px;
+    --color-mktg-btn-shadow-hover: 0 4px 7px rgba(0, 0, 0, 0.15), 0 100px 80px rgba(255, 255, 255, 0.02), 0 42px 33px rgba(255, 255, 255, 0.024), 0 22px 18px rgba(255, 255, 255, 0.028), 0 12px 10px rgba(255, 255, 255, 0.034), 0 7px 5px rgba(255, 255, 255, 0.04), 0 3px 2px rgba(255, 255, 255, 0.07);
+    --color-mktg-btn-shadow-hover-muted: rgb(255 255 255) 0 0 0 2px inset;
     --color-avatar-bg: rgba(240,246,252,0.1);
--- base/dist/scss/colors/_dark_dimmed.scss	2021-11-01 21:04:24.772934985 +0000
+++ dist/scss/colors/_dark_dimmed.scss	2021-11-01 21:04:14.532726637 +0000
@@ -148,33 +148,7 @@
     --color-project-gradient-out: rgba(45,51,59,0);
-    --color-mktg-success: rgba(61,137,66,1);
-    --color-mktg-info: rgba(56,119,213,1);
-    --color-mktg-bg-shade-gradient-top: rgba(28,33,40,0.065);
-    --color-mktg-bg-shade-gradient-bottom: rgba(28,33,40,0);
-    --color-mktg-btn-bg-top: hsla(228,82%,66%,1);
-    --color-mktg-btn-bg-bottom: #4969ed;
-    --color-mktg-btn-bg-overlay-top: hsla(228,74%,59%,1);
-    --color-mktg-btn-bg-overlay-bottom: #3355e0;
-    --color-mktg-btn-text: #cdd9e5;
-    --color-mktg-btn-primary-bg-top: hsla(137,56%,46%,1);
-    --color-mktg-btn-primary-bg-bottom: #2ea44f;
-    --color-mktg-btn-primary-bg-overlay-top: hsla(134,60%,38%,1);
-    --color-mktg-btn-primary-bg-overlay-bottom: #22863a;
-    --color-mktg-btn-primary-text: #cdd9e5;
-    --color-mktg-btn-enterprise-bg-top: hsla(249,100%,72%,1);
-    --color-mktg-btn-enterprise-bg-bottom: #6f57ff;
-    --color-mktg-btn-enterprise-bg-overlay-top: hsla(248,65%,63%,1);
-    --color-mktg-btn-enterprise-bg-overlay-bottom: #614eda;
-    --color-mktg-btn-enterprise-text: #cdd9e5;
-    --color-mktg-btn-outline-text: #cdd9e5;
-    --color-mktg-btn-outline-border: rgba(205,217,229,0.3);
-    --color-mktg-btn-outline-hover-text: #cdd9e5;
-    --color-mktg-btn-outline-hover-border: rgba(205,217,229,0.5);
-    --color-mktg-btn-outline-focus-border: #cdd9e5;
-    --color-mktg-btn-outline-focus-border-inset: rgba(205,217,229,0.5);
-    --color-mktg-btn-dark-text: #cdd9e5;
-    --color-mktg-btn-dark-border: rgba(205,217,229,0.3);
-    --color-mktg-btn-dark-hover-text: #cdd9e5;
-    --color-mktg-btn-dark-hover-border: rgba(205,217,229,0.5);
-    --color-mktg-btn-dark-focus-border: #cdd9e5;
-    --color-mktg-btn-dark-focus-border-inset: rgba(205,217,229,0.5);
+    --color-mktg-btn-bg: #f6f8fa;
+    --color-mktg-btn-shadow-outline: rgb(255 255 255 / 25%) 0 0 0 1px inset;
+    --color-mktg-btn-shadow-focus: rgb(255 255 255 / 25%) 0 0 0 4px;
+    --color-mktg-btn-shadow-hover: 0 4px 7px rgba(0, 0, 0, 0.15), 0 100px 80px rgba(255, 255, 255, 0.02), 0 42px 33px rgba(255, 255, 255, 0.024), 0 22px 18px rgba(255, 255, 255, 0.028), 0 12px 10px rgba(255, 255, 255, 0.034), 0 7px 5px rgba(255, 255, 255, 0.04), 0 3px 2px rgba(255, 255, 255, 0.07);
+    --color-mktg-btn-shadow-hover-muted: rgb(255 255 255) 0 0 0 2px inset;
     --color-avatar-bg: rgba(205,217,229,0.1);
--- base/dist/scss/colors/_dark_high_contrast.scss	2021-11-01 21:04:24.776935067 +0000
+++ dist/scss/colors/_dark_high_contrast.scss	2021-11-01 21:04:14.536726719 +0000
@@ -148,33 +148,7 @@
     --color-project-gradient-out: rgba(39,43,51,0);
-    --color-mktg-success: rgba(9,180,58,1);
-    --color-mktg-info: rgba(64,158,255,1);
-    --color-mktg-bg-shade-gradient-top: rgba(1,4,9,0.065);
-    --color-mktg-bg-shade-gradient-bottom: rgba(1,4,9,0);
-    --color-mktg-btn-bg-top: hsla(228,82%,66%,1);
-    --color-mktg-btn-bg-bottom: #4969ed;
-    --color-mktg-btn-bg-overlay-top: hsla(228,74%,59%,1);
-    --color-mktg-btn-bg-overlay-bottom: #3355e0;
-    --color-mktg-btn-text: #ffffff;
-    --color-mktg-btn-primary-bg-top: hsla(137,56%,46%,1);
-    --color-mktg-btn-primary-bg-bottom: #2ea44f;
-    --color-mktg-btn-primary-bg-overlay-top: hsla(134,60%,38%,1);
-    --color-mktg-btn-primary-bg-overlay-bottom: #22863a;
-    --color-mktg-btn-primary-text: #ffffff;
-    --color-mktg-btn-enterprise-bg-top: hsla(249,100%,72%,1);
-    --color-mktg-btn-enterprise-bg-bottom: #6f57ff;
-    --color-mktg-btn-enterprise-bg-overlay-top: hsla(248,65%,63%,1);
-    --color-mktg-btn-enterprise-bg-overlay-bottom: #614eda;
-    --color-mktg-btn-enterprise-text: #ffffff;
-    --color-mktg-btn-outline-text: #ffffff;
-    --color-mktg-btn-outline-border: rgba(255,255,255,0.3);
-    --color-mktg-btn-outline-hover-text: #ffffff;
-    --color-mktg-btn-outline-hover-border: rgba(255,255,255,0.5);
-    --color-mktg-btn-outline-focus-border: #ffffff;
-    --color-mktg-btn-outline-focus-border-inset: rgba(255,255,255,0.5);
-    --color-mktg-btn-dark-text: #ffffff;
-    --color-mktg-btn-dark-border: rgba(255,255,255,0.3);
-    --color-mktg-btn-dark-hover-text: #ffffff;
-    --color-mktg-btn-dark-hover-border: rgba(255,255,255,0.5);
-    --color-mktg-btn-dark-focus-border: #ffffff;
-    --color-mktg-btn-dark-focus-border-inset: rgba(255,255,255,0.5);
+    --color-mktg-btn-bg: #f6f8fa;
+    --color-mktg-btn-shadow-outline: rgb(255 255 255 / 25%) 0 0 0 1px inset;
+    --color-mktg-btn-shadow-focus: rgb(255 255 255 / 25%) 0 0 0 4px;
+    --color-mktg-btn-shadow-hover: 0 4px 7px rgba(0, 0, 0, 0.15), 0 100px 80px rgba(255, 255, 255, 0.02), 0 42px 33px rgba(255, 255, 255, 0.024), 0 22px 18px rgba(255, 255, 255, 0.028), 0 12px 10px rgba(255, 255, 255, 0.034), 0 7px 5px rgba(255, 255, 255, 0.04), 0 3px 2px rgba(255, 255, 255, 0.07);
+    --color-mktg-btn-shadow-hover-muted: rgb(255 255 255) 0 0 0 2px inset;
     --color-avatar-bg: rgba(255,255,255,0.1);
--- base/dist/scss/colors/_light.scss	2021-11-01 21:04:24.744934415 +0000
+++ dist/scss/colors/_light.scss	2021-11-01 21:04:14.500725987 +0000
@@ -148,33 +148,7 @@
     --color-project-gradient-out: rgba(255,255,255,0);
-    --color-mktg-success: rgba(36,146,67,1);
-    --color-mktg-info: rgba(19,119,234,1);
-    --color-mktg-bg-shade-gradient-top: rgba(27,31,36,0.065);
-    --color-mktg-bg-shade-gradient-bottom: rgba(27,31,36,0);
-    --color-mktg-btn-bg-top: hsla(228,82%,66%,1);
-    --color-mktg-btn-bg-bottom: #4969ed;
-    --color-mktg-btn-bg-overlay-top: hsla(228,74%,59%,1);
-    --color-mktg-btn-bg-overlay-bottom: #3355e0;
-    --color-mktg-btn-text: #ffffff;
-    --color-mktg-btn-primary-bg-top: hsla(137,56%,46%,1);
-    --color-mktg-btn-primary-bg-bottom: #2ea44f;
-    --color-mktg-btn-primary-bg-overlay-top: hsla(134,60%,38%,1);
-    --color-mktg-btn-primary-bg-overlay-bottom: #22863a;
-    --color-mktg-btn-primary-text: #ffffff;
-    --color-mktg-btn-enterprise-bg-top: hsla(249,100%,72%,1);
-    --color-mktg-btn-enterprise-bg-bottom: #6f57ff;
-    --color-mktg-btn-enterprise-bg-overlay-top: hsla(248,65%,63%,1);
-    --color-mktg-btn-enterprise-bg-overlay-bottom: #614eda;
-    --color-mktg-btn-enterprise-text: #ffffff;
-    --color-mktg-btn-outline-text: #4969ed;
-    --color-mktg-btn-outline-border: rgba(73,105,237,0.3);
-    --color-mktg-btn-outline-hover-text: #3355e0;
-    --color-mktg-btn-outline-hover-border: rgba(51,85,224,0.5);
-    --color-mktg-btn-outline-focus-border: #4969ed;
-    --color-mktg-btn-outline-focus-border-inset: rgba(73,105,237,0.5);
-    --color-mktg-btn-dark-text: #ffffff;
-    --color-mktg-btn-dark-border: rgba(255,255,255,0.3);
-    --color-mktg-btn-dark-hover-text: #ffffff;
-    --color-mktg-btn-dark-hover-border: rgba(255,255,255,0.5);
-    --color-mktg-btn-dark-focus-border: #ffffff;
-    --color-mktg-btn-dark-focus-border-inset: rgba(255,255,255,0.5);
+    --color-mktg-btn-bg: #1b1f23;
+    --color-mktg-btn-shadow-outline: rgb(0 0 0 / 15%) 0 0 0 1px inset;
+    --color-mktg-btn-shadow-focus: rgb(0 0 0 / 15%) 0 0 0 4px;
+    --color-mktg-btn-shadow-hover: 0 3px 2px rgba(0, 0, 0, 0.07), 0 7px 5px rgba(0, 0, 0, 0.04), 0 12px 10px rgba(0, 0, 0, 0.03), 0 22px 18px rgba(0, 0, 0, 0.03), 0 42px 33px rgba(0, 0, 0, 0.02), 0 100px 80px rgba(0, 0, 0, 0.02);
+    --color-mktg-btn-shadow-hover-muted: rgb(0 0 0 / 70%) 0 0 0 2px inset;
     --color-avatar-bg: #ffffff;
--- base/dist/scss/colors/_light_colorblind.scss	2021-11-01 21:04:24.760934741 +0000
+++ dist/scss/colors/_light_colorblind.scss	2021-11-01 21:04:14.516726312 +0000
@@ -148,33 +148,7 @@
     --color-project-gradient-out: rgba(255,255,255,0);
-    --color-mktg-success: rgba(3,119,234,1);
-    --color-mktg-info: rgba(19,119,234,1);
-    --color-mktg-bg-shade-gradient-top: rgba(27,31,36,0.065);
-    --color-mktg-bg-shade-gradient-bottom: rgba(27,31,36,0);
-    --color-mktg-btn-bg-top: hsla(228,82%,66%,1);
-    --color-mktg-btn-bg-bottom: #4969ed;
-    --color-mktg-btn-bg-overlay-top: hsla(228,74%,59%,1);
-    --color-mktg-btn-bg-overlay-bottom: #3355e0;
-    --color-mktg-btn-text: #ffffff;
-    --color-mktg-btn-primary-bg-top: hsla(137,56%,46%,1);
-    --color-mktg-btn-primary-bg-bottom: #2ea44f;
-    --color-mktg-btn-primary-bg-overlay-top: hsla(134,60%,38%,1);
-    --color-mktg-btn-primary-bg-overlay-bottom: #22863a;
-    --color-mktg-btn-primary-text: #ffffff;
-    --color-mktg-btn-enterprise-bg-top: hsla(249,100%,72%,1);
-    --color-mktg-btn-enterprise-bg-bottom: #6f57ff;
-    --color-mktg-btn-enterprise-bg-overlay-top: hsla(248,65%,63%,1);
-    --color-mktg-btn-enterprise-bg-overlay-bottom: #614eda;
-    --color-mktg-btn-enterprise-text: #ffffff;
-    --color-mktg-btn-outline-text: #4969ed;
-    --color-mktg-btn-outline-border: rgba(73,105,237,0.3);
-    --color-mktg-btn-outline-hover-text: #3355e0;
-    --color-mktg-btn-outline-hover-border: rgba(51,85,224,0.5);
-    --color-mktg-btn-outline-focus-border: #4969ed;
-    --color-mktg-btn-outline-focus-border-inset: rgba(73,105,237,0.5);
-    --color-mktg-btn-dark-text: #ffffff;
-    --color-mktg-btn-dark-border: rgba(255,255,255,0.3);
-    --color-mktg-btn-dark-hover-text: #ffffff;
-    --color-mktg-btn-dark-hover-border: rgba(255,255,255,0.5);
-    --color-mktg-btn-dark-focus-border: #ffffff;
-    --color-mktg-btn-dark-focus-border-inset: rgba(255,255,255,0.5);
+    --color-mktg-btn-bg: #1b1f23;
+    --color-mktg-btn-shadow-outline: rgb(0 0 0 / 15%) 0 0 0 1px inset;
+    --color-mktg-btn-shadow-focus: rgb(0 0 0 / 15%) 0 0 0 4px;
+    --color-mktg-btn-shadow-hover: 0 3px 2px rgba(0, 0, 0, 0.07), 0 7px 5px rgba(0, 0, 0, 0.04), 0 12px 10px rgba(0, 0, 0, 0.03), 0 22px 18px rgba(0, 0, 0, 0.03), 0 42px 33px rgba(0, 0, 0, 0.02), 0 100px 80px rgba(0, 0, 0, 0.02);
+    --color-mktg-btn-shadow-hover-muted: rgb(0 0 0 / 70%) 0 0 0 2px inset;
     --color-avatar-bg: #ffffff;

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question: Are these variables meant for all themes or only the light and dark, but not dark_dimmed, dark_high_contrast etc.

The reason for asking is that using hex values like #f6f8fa will be the same in all dark themes. Is that ok?

@tobiasahlin
Copy link
Contributor Author

@simurai Yesss, right now that's the plan 🙏 we don't have any other variants defined or in the roadmap, and these variants should work well in both dark and dark_dimmed, etc (contrast wise)

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss, right now that's the plan 🙏 we don't have any other variants defined or in the roadmap, and these variants should work well in both dark and dark_dimmed, etc (contrast wise)

Ok, great. Diff looks a lot simpler now. ✌️

@jonrohan jonrohan changed the base branch from main to next_major November 3, 2021 21:06
@jonrohan jonrohan requested review from a team and jfuchs November 3, 2021 21:06
@jonrohan jonrohan merged commit 9517ebb into next_major Nov 3, 2021
@jonrohan jonrohan deleted the tobiasahlin/prepare-for-mktg-buttons-v2 branch November 3, 2021 21:06
@primer-css primer-css mentioned this pull request Nov 3, 2021
@simurai simurai mentioned this pull request Nov 8, 2021
simurai added a commit that referenced this pull request Nov 9, 2021
* Creating next_major branch for major releases

* Rename color blind themes (#254)

* Rename protanopia themes to colorblind

* Rename protanopia themes to colorblind

* Create green-apples-hang.md

* Update green-apples-hang.md

* Delete pre.json

* Add pre.json

* Prepare for new gloss buttons with color mode support (#265)

* Clean up unused vars

* Clean up unused utilities

* Clean up light colors

* Prep for new color mode supported gloss buttons

* Create swift-berries-learn.md

Co-authored-by: Jon Rohan <[email protected]>

* This changeset was already shipped

* Delete pre.json

Co-authored-by: Jon Rohan <[email protected]>
Co-authored-by: Tobias Ahlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants