Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix and root cause analysis (RCA): Failing integration tests #113

Merged
merged 4 commits into from
Nov 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/integration_test_astro.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
push:
branches:
- main
schedule:
- cron: '0 0 * * *' # end of each day (UTC)
pull_request:

env:
Expand Down Expand Up @@ -67,7 +69,9 @@ jobs:
run: cd packages/react/ && npm pack

- name: Configuring Astro React / TypeScript project
run: npm create astro@latest ${{env.ASTRO_FOLDER}} -- --template framework-react
# lock version to 1.1.0 due to non-tty support removed in 1.2.0
# TODO: review Astro updates regularly to using @latest
run: npm create [email protected] ${{env.ASTRO_FOLDER}} -- --template framework-react

- name: Retrieving package version
id: package-version
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/integration_test_cra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
push:
branches:
- main
schedule:
- cron: '0 0 * * *' # end of each day (UTC)
pull_request:

env:
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/integration_test_nextjs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
push:
branches:
- main
schedule:
- cron: '0 0 * * *' # end of each day (UTC)
pull_request:

env:
Expand Down Expand Up @@ -77,7 +79,7 @@ jobs:

- name: Installing local build
run: |
cd ${{env.NEXTJS_FOLDER}}
cd ${{env.NEXTJS_FOLDER}}
cp ../packages/react/primer-react-brand-${{ steps.package-version.outputs.current-version}}.tgz ./
npm install primer-react-brand-${{ steps.package-version.outputs.current-version}}.tgz

Expand All @@ -89,6 +91,7 @@ jobs:
- name: Copying required files
run: |
cp ./packages/e2e/integration-tests/nextjs/index.tsx ./${{env.NEXTJS_FOLDER}}/pages
cp ./packages/e2e/integration-tests/nextjs/.eslintrc ./${{env.NEXTJS_FOLDER}}
cp ./packages/e2e/cypress.config.js ./${{env.NEXTJS_FOLDER}}
mkdir ${{env.NEXTJS_FOLDER}}/integration-tests
cp -r ./packages/e2e/integration-tests/fixtures ./${{env.NEXTJS_FOLDER}}/integration-tests
Expand All @@ -105,6 +108,10 @@ jobs:
- name: Excluded cypress tests in-place
run: npx json -I -f ${{env.NEXTJS_FOLDER}}/tsconfig.json -e 'this.exclude=["node_modules", "**/*.cy.ts"]'

- name: Fix monorepo-related linting issues
run: |
npm run lint -- --fix

- name: Testing compile-time build
run: cd ${{env.NEXTJS_FOLDER}} && npm run build

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/integration_test_remix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
push:
branches:
- main
schedule:
- cron: '0 0 * * *' # end of each day (UTC)
pull_request:

env:
Expand Down
8 changes: 8 additions & 0 deletions packages/e2e/integration-tests/nextjs/.eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"extends": "next",
"rules": {
"eslint-comments/no-unlimited-disable": "off",
"eslint-comments/no-use": "off",
"react/react-in-jsx-scope": "off"
}
}