Hotfix and root cause analysis (RCA): Failing integration tests #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
End-to-end integration tests for Astro and Next.js were - rather coincidentally - failing at the same time.
This was first detected in PR's, but hasn't impacted main branch yet as it hasn't run the integration tests since its last push.
This PR fixes the issue and serves as an RCA for what occurred, and how the problem was remediated.
Timeline*
Contributing Factors (Root Causes, Triggers)
next lint
as a prebuild step inv13.0.1
. This caused linting issues to fail the Next.js integration testmain
branch didn't fail and notify maintainers because it hadn't run since the above packages were last updated.Stabilization Steps
main
.Lessons Learned
main
branch to notice these errors sooner. There was a gap of >4 days between release of the breaking change in Astro and when we first observed the failing build.Corrective Actions in this PR
main
branch.Next steps
main
branch.