Add appendTo to Dialog to control Teleport #1440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! So sorry :( I have not seen this PR. Fixed in #1483 Unfortunately, I have to close this PR. Sorry again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears
Dialogwas missed in the fixes for #1148We're having trouble with unit tests for components that involve Dialogs, due to the dialog content being teleported outside of the component. The common advice from vue-test-utils is to use another internal component, but that interferes with the ability to use slots in the Dialog.
This should allow us to set
appendTo="self"during unit tests, to disable the teleporting behaviour.